From b5a2c59a5f307340ee2944aef0e25795735bc8b4 Mon Sep 17 00:00:00 2001
From: Karthic Ravindran <karthic.ravindran@oracle.com>
Date: Thu, 2 Sep 2021 09:05:57 +0530
Subject: [PATCH] doc changes and linting

---
 README.md                       | 4 ++--
 docs/quickstart.adoc            | 2 +-
 docs/terraformoptions.adoc      | 3 +--
 main.tf                         | 2 +-
 modules/function/functionlog.tf | 3 +--
 modules/lb/lblog.tf             | 2 --
 6 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index dcd997b..30caac3 100644
--- a/README.md
+++ b/README.md
@@ -57,8 +57,8 @@ Licensed under the [Universal Permissive License 1.0][license] as shown at
 [prerequisites]: https://github.com/oracle-terraform-modules/terraform-oci-logging/blob/main/docs/prerequisites.adoc
 
 [quickstart]: https://github.com/oracle-terraform-modules/terraform-oci-logging/blob/main/docs/quickstart.adoc
-[repo]: https://github.com/oracle/terraform-oci-logging
-[reuse]: https://github.com/oracle/terraform-oci-logging/examples
+[repo]: https://github.com/oracle-terraform-modules/terraform-oci-logging
+[reuse]: https://github.com/oracle-terraform-modules/terraform-oci-logging/examples
 [terraform]: https://www.terraform.io
 [terraform_oci]: https://www.terraform.io/docs/providers/oci/index.html
 [terraform_options]: https://github.com/oracle-terraform-modules/terraform-oci-logging/blob/main/docs/terraformoptions.adoc
diff --git a/docs/quickstart.adoc b/docs/quickstart.adoc
index 670fdcc..df03ea4 100644
--- a/docs/quickstart.adoc
+++ b/docs/quickstart.adoc
@@ -53,7 +53,7 @@ cp terraform.tfvars.example terraform.tfvars
 [source,hcl]
 ----
 provider "oci" {
-  tenancy_id         = var.tenancy_id
+  tenancy_id           = var.tenancy_id
   user_ocid            = var.user_id
   fingerprint          = var.api_fingerprint
   private_key_path     = var.api_private_key_path
diff --git a/docs/terraformoptions.adoc b/docs/terraformoptions.adoc
index 301d0ed..c67abf5 100644
--- a/docs/terraformoptions.adoc
+++ b/docs/terraformoptions.adoc
@@ -62,8 +62,7 @@
 [source]
 ----
 loggroup_tags = {
-  department = "finance"
-  environment = "dev"
+  "Environment" = "Dev"
 }
 ----
 |loggroup_tags = {
diff --git a/main.tf b/main.tf
index ed471c4..1089061 100644
--- a/main.tf
+++ b/main.tf
@@ -52,7 +52,7 @@ resource "oci_logging_log_group" "funcloggroup" {
   for_each = toset(local.funcloggroup)
 
   compartment_id = var.compartment_id
-  description    = "FunctionsLoggroup"
+  description    = "Functions Loggroup"
   display_name   = each.value
   freeform_tags  = var.loggroup_tags
 
diff --git a/modules/function/functionlog.tf b/modules/function/functionlog.tf
index 62dfed0..11dddd3 100644
--- a/modules/function/functionlog.tf
+++ b/modules/function/functionlog.tf
@@ -5,8 +5,7 @@ data "oci_functions_applications" "func_apps" {
 
   #Optional
   display_name = each.value.resource
-  #id           = oci_functions_application.test_application.id
-  #state = "AVAILABLE"
+
 }
 
 
diff --git a/modules/lb/lblog.tf b/modules/lb/lblog.tf
index 2e2bcde..0174c6a 100644
--- a/modules/lb/lblog.tf
+++ b/modules/lb/lblog.tf
@@ -3,8 +3,6 @@ data "oci_load_balancer_load_balancers" "load_balancers" {
   for_each       = var.logdefinition
   compartment_id = var.compartment_id
 
-  #Optional
-  #detail       = var.load_balancer_detail
   display_name = each.value.resource
   state        = "ACTIVE"
 }