From 1af30c945959fb0a69610e68722e13badf04462c Mon Sep 17 00:00:00 2001 From: FarhanAnjum-opti Date: Wed, 11 Dec 2024 00:21:43 +0600 Subject: [PATCH 1/2] testing commit --- lib/optimizely.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/optimizely.rb b/lib/optimizely.rb index 1dbd54c4..e701b599 100644 --- a/lib/optimizely.rb +++ b/lib/optimizely.rb @@ -15,6 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the License. # +# This is just a test branch require_relative 'optimizely/audience' require_relative 'optimizely/config/datafile_project_config' require_relative 'optimizely/config_manager/http_project_config_manager' From d990bbe39aee676f975c573fa4ec503bac914807 Mon Sep 17 00:00:00 2001 From: FarhanAnjum-opti Date: Wed, 11 Dec 2024 00:27:27 +0600 Subject: [PATCH 2/2] linting mistakes corrected --- lib/optimizely/helpers/validator.rb | 4 ++-- lib/optimizely/optimizely_factory.rb | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/optimizely/helpers/validator.rb b/lib/optimizely/helpers/validator.rb index d3baa447..4d975483 100644 --- a/lib/optimizely/helpers/validator.rb +++ b/lib/optimizely/helpers/validator.rb @@ -122,11 +122,11 @@ def inputs_valid?(variables, logger = NoOpLogger.new, level = Logger::ERROR) return false unless variables.respond_to?(:each) && !variables.empty? - is_valid = true + is_valid = true # rubocop:disable Lint/UselessAssignment if variables.include? :user_id # Empty str is a valid user ID. unless variables[:user_id].is_a?(String) - is_valid = false + is_valid = false # rubocop:disable Lint/UselessAssignment logger.log(level, "#{Constants::INPUT_VARIABLES['USER_ID']} is invalid") end variables.delete :user_id diff --git a/lib/optimizely/optimizely_factory.rb b/lib/optimizely/optimizely_factory.rb index 04c7ecdd..717e43d9 100644 --- a/lib/optimizely/optimizely_factory.rb +++ b/lib/optimizely/optimizely_factory.rb @@ -142,7 +142,6 @@ def self.custom_instance( # rubocop:disable Metrics/ParameterLists notification_center = nil, settings = nil ) - error_handler ||= NoOpErrorHandler.new logger ||= NoOpLogger.new notification_center = notification_center.is_a?(Optimizely::NotificationCenter) ? notification_center : NotificationCenter.new(logger, error_handler)