From 12773d1bb6ef32fb19b46f2799ad1d01eed73938 Mon Sep 17 00:00:00 2001 From: Pulak Bhowmick Date: Thu, 23 Nov 2023 23:27:40 +0600 Subject: [PATCH] improve logging --- cmd/optimizely/main.go | 3 +++ pkg/handlers/webhook.go | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/cmd/optimizely/main.go b/cmd/optimizely/main.go index c99d4932..2ea00f88 100644 --- a/cmd/optimizely/main.go +++ b/cmd/optimizely/main.go @@ -33,6 +33,7 @@ import ( "github.com/spf13/viper" "github.com/optimizely/agent/config" + "github.com/optimizely/agent/pkg/handlers" "github.com/optimizely/agent/pkg/metrics" "github.com/optimizely/agent/pkg/optimizely" "github.com/optimizely/agent/pkg/routers" @@ -267,6 +268,8 @@ func main() { ctx, cancel := context.WithCancel(context.Background()) // Create default service context defer cancel() + ctx = context.WithValue(ctx, handlers.LoggerKey, &log.Logger) + sg := server.NewGroup(ctx, conf.Server) // Create a new server group to manage the individual http listeners optlyCache := optimizely.NewCache(ctx, *conf, sdkMetricsRegistry) optlyCache.Init(conf.SDKKeys) diff --git a/pkg/handlers/webhook.go b/pkg/handlers/webhook.go index 0cadce79..48728db5 100644 --- a/pkg/handlers/webhook.go +++ b/pkg/handlers/webhook.go @@ -164,7 +164,7 @@ func (h *OptlyWebhookHandler) HandleWebhook(w http.ResponseWriter, r *http.Reque func (h *OptlyWebhookHandler) StartSyncer(ctx context.Context) error { logger, ok := ctx.Value(LoggerKey).(*zerolog.Logger) if !ok { - logger = &zerolog.Logger{} + logger = &log.Logger } if !h.syncEnabled { @@ -185,8 +185,10 @@ func (h *OptlyWebhookHandler) StartSyncer(ctx context.Context) error { return case key := <-dataCh: h.optlyCache.UpdateConfigs(key) + logger.Debug().Msg("datafile synced successfully") } } }() + logger.Debug().Msg("datafile syncer is started") return nil }