Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leave customElement registration up to apps #206

Open
samuelstroschein opened this issue Dec 12, 2024 — with Linear · 2 comments
Open

leave customElement registration up to apps #206

samuelstroschein opened this issue Dec 12, 2024 — with Linear · 2 comments
Labels
Refactor

Comments

@samuelstroschein Linear
Copy link
Member

Context

The diff components register the components themselves.

  • requires validation and documentation on standard schema
  • reduces flexibility of apps
  • registers components even in environments where components are not needed (server)

CleanShot 2024-12-12 at 14.32.25@2x.png

Proposal

Don't register the components in the plugin. Let apps register the components.

  • no need to come up with and validate a standard naming scheme
  • apps have flexibility over naming
  • components are not registered when not needed
@samuelstroschein Linear
Copy link
Member Author

cc @niklas.buchfink. saw the piece of code in https://www.loom.com/share/89a525a5b68946a8ad4aa12a567726db

@NiklasBuchfink Linear
Copy link
Member

Jup, I agree. Makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samuelstroschein @NiklasBuchfink