Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key load error: Couldn't GET http://127.0.0.1:8080/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx: No error #361

Open
oldshensheep opened this issue Mar 17, 2024 · 2 comments

Comments

@oldshensheep
Copy link

System information

Type Version/Name
Distribution Name Windows 11 Pro
Distribution Version 23H2
Kernel Version 22635.3212
Architecture x64
OpenZFS Version OpenZFSOnWindows-debug-in-2.2.3rc1.exe

Describe the problem you're observing

like #359 but new error

❯ zfs load-key -a
Key load error: Couldn't GET http://127.0.0.1:8080/xxxxxxxxxxxxxxxxxxxxxxxxxxxxx: No error
Key load error: Couldn't GET http://127.0.0.1:8080/yyyyyyyyyyyyyyyyyyyyyyyyyyyy: No error
0 / 2 key(s) successfully loaded
❯ curl http://127.0.0.1:8080/xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
<something>

Describe how to reproduce the problem

Include any warning/errors/backtraces from the system logs

@lundman
Copy link

lundman commented Mar 17, 2024

It was a pretty fast port - so it looks like it isn't bubbling the error back up.

@lundman
Copy link

lundman commented Mar 21, 2024

Note to self, fetching successfully and errors does appear to work, but the call to getline() is incorrect, it has to handle the expansion by calling realloc() and setting *linep. Quite noticeable if verbose is enabled, as it tries to read into a NULL ptr.

Also seems ZFS has no way to pass Verbose into libfetch. Perhaps we should fetch from env vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants