frr failed to build in recent 23.05.x for some targets

[vochong]

frr failed in build in 23.05.x for some targets such as "target-arm_cortex-a7+neon-vfpv4_musl_eabi", "target-powerpc_8548_musl" etc.

However, it works for "target-arm_cortex-a15+neon-vfpv4_musl_eabi".

@lucize
Maintainer: @lucize
Environment: target-arm_cortex-a7+neon-vfpv4_musl_eabi, 23.05.x

Description:

Makefile:4278: WARNING: you have overwritten the "CC" variable on the make command line.
Makefile:4290: WARNING: you have overwritten the "LD" variable on the make command line.
Makefile:4297: ------
Makefile:4298: While overwriting these variables works most of the time, it is not recommended and can cause confusing build errors.
Makefile:4299: This is especially problematic when cross-compiling, since tools that run on the build system during the build process will not be compiled correctly.
Makefile:4300: All of these variables should be supplied to 'configure', and they will be remembered and correctly applied during 'make'.
Makefile:4301: ------
true
make  all-am
make[4]: Entering directory '/home/user/.owrt/openwrt-23.05-all/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/frr-05469ab2b553302c2a7032f4c89e4510dc3fa6d9'
Makefile:4278: WARNING: you have overwritten the "CC" variable on the make command line.
Makefile:4290: WARNING: you have overwritten the "LD" variable on the make command line.
Makefile:4297: ------
Makefile:4298: While overwriting these variables works most of the time, it is not recommended and can cause confusing build errors.
Makefile:4299: This is especially problematic when cross-compiling, since tools that run on the build system during the build process will not be compiled correctly.
Makefile:4300: All of these variables should be supplied to 'configure', and they will be remembered and correctly applied during 'make'.
Makefile:4301: ------
/bin/bash ./libtool  --tag=CC   --mode=link arm-openwrt-linux-muslgnueabi-gcc -fms-extensions -fno-omit-frame-pointer -funwind-tables -Wall -Wextra -Wformat-nonliteral -Wformat-security -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wundef -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers  -I/home/user/.owrt/openwrt-23.05-all/staging_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/usr/include      -DPIM_IPV=4 -Os -pipe -fno-caller-saves -fno-plt -fhonour-copts -mfloat-abi=hard -fmacro-prefix-map=/home/user/.owrt/openwrt-23.05-all/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/frr-05469ab2b553302c2a7032f4c89e4510dc3fa6d9=frr-05469ab2b553302c2a7032f4c89e4510dc3fa6d9 -flto=auto -fno-fat-lto-objects -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro  -export-dynamic     -L/home/user/.owrt/openwrt-23.05-all/staging_dir/toolchain-arm_cortex-a7+neon-vfpv4_gcc-12.3.0_musl_eabi/usr/lib -L/home/user/.owrt/openwrt-23.05-all/staging_dir/toolchain-arm_cortex-a7+neon-vfpv4_gcc-12.3.0_musl_eabi/lib -flto=auto -fuse-linker-plugin -znow -zrelro -Wl,--gc-sections,--as-needed -latomic  -g -o pimd/mtracebis pimd/mtracebis-mtracebis.o pimd/mtracebis-mtracebis_netlink.o pimd/mtracebis-mtracebis_routeget.o lib/libfrr.la -lresolv   -ljson-c -lrt
OpenWrt-libtool: link: arm-openwrt-linux-muslgnueabi-gcc -fms-extensions -fno-omit-frame-pointer -funwind-tables -Wall -Wextra -Wformat-nonliteral -Wformat-security -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wundef -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -I/home/user/.owrt/openwrt-23.05-all/staging_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/usr/include -DPIM_IPV=4 -Os -pipe -fno-caller-saves -fno-plt -fhonour-copts -mfloat-abi=hard -fmacro-prefix-map=/home/user/.owrt/openwrt-23.05-all/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/frr-05469ab2b553302c2a7032f4c89e4510dc3fa6d9=frr-05469ab2b553302c2a7032f4c89e4510dc3fa6d9 -flto=auto -fno-fat-lto-objects -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z -Wl,now -Wl,-z -Wl,relro -flto=auto -fuse-linker-plugin -znow -zrelro -Wl,--gc-sections -Wl,--as-needed -g -o pimd/.libs/mtracebis pimd/mtracebis-mtracebis.o pimd/mtracebis-mtracebis_netlink.o pimd/mtracebis-mtracebis_routeget.o -Wl,--export-dynamic  -L/home/user/.owrt/openwrt-23.05-all/staging_dir/toolchain-arm_cortex-a7+neon-vfpv4_gcc-12.3.0_musl_eabi/usr/lib -L/home/user/.owrt/openwrt-23.05-all/staging_dir/toolchain-arm_cortex-a7+neon-vfpv4_gcc-12.3.0_musl_eabi/lib lib/.libs/libfrr.so -L/home/user/.owrt/openwrt-23.05-all/staging_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/usr/lib /home/user/.owrt/openwrt-23.05-all/staging_dir/toolchain-arm_cortex-a7+neon-vfpv4_gcc-12.3.0_musl_eabi/lib/libatomic.so -lcap -lyang -lcrypt -lresolv -ljson-c -lrt -pthread -Wl,-rpath -Wl,/home/user/.owrt/openwrt-23.05-all/staging_dir/toolchain-arm_cortex-a7+neon-vfpv4_gcc-12.3.0_musl_eabi/lib
/home/user/.owrt/openwrt-23.05-all/staging_dir/toolchain-arm_cortex-a7+neon-vfpv4_gcc-12.3.0_musl_eabi/lib/gcc/arm-openwrt-linux-muslgnueabi/12.3.0/../../../../arm-openwrt-linux-muslgnueabi/bin/ld: lib/.libs/libfrr.so: undefined reference to `vty_pass_fd'
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:8102: pimd/mtracebis] Error 1
make[4]: Leaving directory '/home/user/.owrt/openwrt-23.05-all/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/frr-05469ab2b553302c2a7032f4c89e4510dc3fa6d9'
make[3]: *** [Makefile:6245: all] Error 2
make[3]: Leaving directory '/home/user/.owrt/openwrt-23.05-all/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/frr-05469ab2b553302c2a7032f4c89e4510dc3fa6d9'
make[2]: *** [Makefile:247: /home/user/.owrt/openwrt-23.05-all/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/frr-05469ab2b553302c2a7032f4c89e4510dc3fa6d9/.built] Error 2
make[2]: Leaving directory '/home/user/.owrt/openwrt-23.05-all/feeds/packages/net/frr'
time: package/feeds/packages/frr/compile#0.65#0.45#1.02
    ERROR: package/feeds/packages/frr failed to build.
make[1]: *** [package/Makefile:129: package/feeds/packages/frr/compile] Error 1
make[1]: Leaving directory '/home/user/.owrt/openwrt-23.05-all'
make: *** [/home/user/.owrt/openwrt-23.05-all/include/toplevel.mk:233: package/feeds/packages/frr/compile] Error 2