Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-ddns: Helpful changes #5297

Open
LecrisUT opened this issue Aug 24, 2021 · 2 comments
Open

luci-app-ddns: Helpful changes #5297

LecrisUT opened this issue Aug 24, 2021 · 2 comments
Assignees

Comments

@LecrisUT
Copy link

The current field names and settings for the ddns app are very confusing for both users and maintainers. There are issues opened about this like #2436 and various other by confused users. I would propose the following changes:

  1. Allow the script maintainers to add, remove, rename, and set properties (hidden, required etc.) to fields via a .json file. For example this can look like:
{
   "name": "My new DDNS script",
   "fields": [ {
      "name": "record name",
      "required": true
   }, {
      "name": "domain",
      "required": true
   }]
}
  1. For ddns-scripts, provide a complete example curl script including any possible error catchers. There are some issues out there linked to an incomplete ddns-script. This could also be used to add better tests for the CI.
  2. Add a view log option outside the edit dialog, and output any or all the contents in the \var\log, DATFILE, ERRFILE.
  3. Lowest priority, but would definitely be appreciated: Provide a contact method for when any of the scripts are failing.

Situations where this is helpful:

  • Remove the confusion when you have to input the record name into the username field.
  • Allow ddns on local servers like PowerDNS
  • Simplify and clarify scripts, e.g. remove the need for param_opt

I understand that this could break some of the current ddns-scripts, however some of them could use a rewrite to better manage error at the very least.

@feckert feckert self-assigned this Aug 30, 2021
@feckert
Copy link
Member

feckert commented Oct 19, 2021

I agree with you completely. That's why I changed the database to json. Before, it was a file with which you added or deleted something with SED. If you want, you can create a proof of concept how you imagine it, then I can look at it in the code.

@adelton
Copy link
Contributor

adelton commented Jan 11, 2025

I now filed #7559 to actually show the Update URL. It is not the general customization suggested here but given this issue did not get addressed so far, maybe being able to see the URL in the UI with the placeholders might help a bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants