-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should synclass() in Connection return neurotransmitter info? #401
Comments
Yes, the data source the connections are created from in this case don't populate the |
Thanks for checking. That will most likely be needed so OpenWormReader can pass the correct info on synapse types to c302. |
- Also, updating the classes for #401
I've added the "synclass" entries from the Shterionov (2011) data that we had been using to the openworm/OpenWormData repo, but found that there's a pretty big mismatch between that and the data from wormwiring.org that we're using now. I've created a separate ticket, #419, to address the gap since I think this issue is answered by the inclusion of some neurotransmitters. |
- Avoids an annoying rewrite of tests for POW::save - Also making another correction for #401 translator
- Avoids an annoying rewrite of tests for POW::save - Also making another correction for #401 translator
It seems like synclass() here: https://github.com/openworm/PyOpenWorm/blob/c46def3023f1f0946873267883c0351066038711/PyOpenWorm/connection.py#L38 should return the neurotransmitter, e.g. see https://github.com/openworm/PyOpenWorm/blob/c46def3023f1f0946873267883c0351066038711/examples/NetworkInfo.py#L55, but it returns None.
Output of https://github.com/openworm/c302/blob/feature/update-openworm-reader-10/c302/OpenWormReader.py should have info on neurotransmitter (the fact thta the connections are missing is a different issue):
The text was updated successfully, but these errors were encountered: