Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should synclass() in Connection return neurotransmitter info? #401

Closed
pgleeson opened this issue May 8, 2019 · 3 comments
Closed

Should synclass() in Connection return neurotransmitter info? #401

pgleeson opened this issue May 8, 2019 · 3 comments

Comments

@pgleeson
Copy link
Member

pgleeson commented May 8, 2019

It seems like synclass() here: https://github.com/openworm/PyOpenWorm/blob/c46def3023f1f0946873267883c0351066038711/PyOpenWorm/connection.py#L38 should return the neurotransmitter, e.g. see https://github.com/openworm/PyOpenWorm/blob/c46def3023f1f0946873267883c0351066038711/examples/NetworkInfo.py#L55, but it returns None.

Output of https://github.com/openworm/c302/blob/feature/update-openworm-reader-10/c302/OpenWormReader.py should have info on neurotransmitter (the fact thta the connections are missing is a different issue):

...
c302      >>>  Missing from UpdatedSpreadsheetDataReader: Connection from VM2PR to VC3 (2 times, type: GapJunction, neurotransmitter: None)
c302      >>>  Missing from UpdatedSpreadsheetDataReader: Connection from PM4DR to I3 (3 times, type: GapJunction, neurotransmitter: None)
c302      >>>  Missing from UpdatedSpreadsheetDataReader: Connection from PM5VL to M5 (2 times, type: GapJunction, neurotransmitter: None)
c302      >>>  Missing from UpdatedSpreadsheetDataReader: Connection from PM5DL to M2R (1 times, type: GapJunction, neurotransmitter: None)

...
@mwatts15
Copy link
Contributor

mwatts15 commented May 8, 2019

Yes, the data source the connections are created from in this case don't populate the synclass.

@pgleeson
Copy link
Member Author

Thanks for checking. That will most likely be needed so OpenWormReader can pass the correct info on synapse types to c302.

@mwatts15
Copy link
Contributor

mwatts15 commented Jun 9, 2019

I've added the "synclass" entries from the Shterionov (2011) data that we had been using to the openworm/OpenWormData repo, but found that there's a pretty big mismatch between that and the data from wormwiring.org that we're using now.

I've created a separate ticket, #419, to address the gap since I think this issue is answered by the inclusion of some neurotransmitters.

@mwatts15 mwatts15 closed this as completed Jun 9, 2019
mwatts15 added a commit that referenced this issue Jun 10, 2019
- Avoids an annoying rewrite of tests for POW::save
- Also making another correction for #401 translator
mwatts15 added a commit that referenced this issue Jun 10, 2019
- Avoids an annoying rewrite of tests for POW::save
- Also making another correction for #401 translator
@mwatts15 mwatts15 unpinned this issue Sep 10, 2019
mwatts15 added a commit that referenced this issue Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants