Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website element display doesn't know about closed ways ... #1147

Open
simonpoole opened this issue Feb 3, 2016 · 4 comments · May be fixed by #5393 or #5317
Open

Website element display doesn't know about closed ways ... #1147

simonpoole opened this issue Feb 3, 2016 · 4 comments · May be fixed by #5393 or #5317

Comments

@simonpoole
Copy link
Contributor

Super serious, major major, must be fixed tomorrow issue :-).

On the other hand it has likely been aournd since we have the rails port so I suppose we could just continue to ignore it.

See for example http://www.openstreetmap.org/way/189128109 node #3984033658 is the end and start node of the adjacent polygon.

Don't ask why I noticed this in the first place. If I'm not too lazy I might submit a PR:

@tomhughes
Copy link
Member

Could you explain what exactly you are expecting it to do that it doesn't do?

In general neither the API nor anything else on the server has any concept of something being closed as we don't have an area type. Some editors may treat lines which start and end with the same point specially and apparently you would like the browser view on the web site to do so, but you haven't said what it is you would like it to do.

@Zverik
Copy link
Contributor

Zverik commented Feb 5, 2016

He means, the list has the node as a member of the same way referenced two times: 3984033658 (member of ways 395560549 и 395560549). It should be a set, not a list.

@simonpoole
Copy link
Contributor Author

It can be argued that the duplicate mention of the (same) way is language wise an error in any case. Maybe a simple language change is enough to make it cleaner.

@mmd-osm
Copy link
Contributor

mmd-osm commented Jun 25, 2024

Old example is buried somewhere in way history, new example: https://www.openstreetmap.org/way/4683291

image

image

Way 38816094 is shown twice for node 29761716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants