Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add website field to standard preset for shops/amenities #1413

Open
forteller opened this issue Dec 21, 2024 · 4 comments
Open

Add website field to standard preset for shops/amenities #1413

forteller opened this issue Dec 21, 2024 · 4 comments

Comments

@forteller
Copy link

OSM Tag(s)

website=

How would you like this tag to see supported?

As a Field

Label

Website

Aliases

No response

Terms

No response

Link to OSM Wiki page

https://wiki.openstreetmap.org/wiki/Key:website

Status of the Tag

De Facto

Usage of the tag

Tons

Suggested Icon

No response

Replaces other Tag?

No response

Regional Tag?

No response

Further Information

Most people in many countries today would probably rather use a website to get more info about and contact a shop or similar, rather than their phone number. Yet the phone field is always shown, while you have to manually add the website field to a lot of establishments. It's shown by default on some, but not on many.

Here are some examples:

shop=camera
shop=supermarket
shop=bicycle
amenity=bicycle_rental
shop=mall
shop=yes
shop=books
shop=anime
leisure=sports_centre
amenity=bar
amenity=ice_cream
amenity=library

Hope you can look into this, which would make editing easier and more enjoyable for me. Thank you for your work!

See also openstreetmap/iD#7877

@forteller forteller added the needs-triage This is a fresh issue which has not yet been looked over by the maintainers of this repository. label Dec 21, 2024
@maro-21
Copy link

maro-21 commented Dec 24, 2024

I agree and support!
Please swap phone field with website on shops and add it in other presets.

@tordans
Copy link
Collaborator

tordans commented Dec 25, 2024

The question to me is, which is the best place to add this field.

We could add it to the top level shop preset https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/shop.json

=> Which means all shop/*.json will have it.

We could add it as a moreFields to the @template/poi that the global shop preset uses.

=> Which means about 85 POI would use it https://github.com/search?q=repo%3Aopenstreetmap%2Fid-tagging-schema+%22%40templates%2Fpoi%22+path%3A%2F%5Edata%5C%2Fpresets%5C%2F%2F&type=code

In this case, we would have to look at those 85 files and check if the website key is now duplicated and remove it. That is not really required, but I think this kind of cleanup will help keep the data easier to maintain.

@DujaOSM
Copy link

DujaOSM commented Dec 30, 2024

It's touchy...
We could add that to the parent templates such as shop and amenity, but it would then provide some rather silly results for...

  • features that are regularly part of chains, and seldom have a dedicated website (at most, a separate page on the chain's website): amenity=bank, amenity=fuel, amenity=pharmacy, shop=supermarket...
  • features that seldom if ever have a website: amenity=ice_cream, amenity=bureau_de_change, amenity=bicycle_wash, amenity=food_court...

I guess the first case is less problematic than the second (one can reasonably target a subpage), but suggesting adding a website that hardly exists just occupies screen estate and invites populating bad data.

@k-yle
Copy link
Collaborator

k-yle commented Dec 30, 2024

We could add it as a moreFields to the @template/poi that the global shop preset uses.

website has already been added to moreFields for every preset (as of #503), so this discussion should focus on which presets should show website by default

@k-yle k-yle added add-field and removed needs-triage This is a fresh issue which has not yet been looked over by the maintainers of this repository. labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants