Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRLF/LF errors when runing test on Windows #10628

Closed
Nekzuris opened this issue Dec 24, 2024 · 1 comment · Fixed by #10647
Closed

CRLF/LF errors when runing test on Windows #10628

Nekzuris opened this issue Dec 24, 2024 · 1 comment · Fixed by #10647

Comments

@Nekzuris
Copy link
Contributor

Nekzuris commented Dec 24, 2024 •
edited
Loading

How to reproduce the issue?

Run npm test after cloning on windows.

The 3 .mjs file in /config/ are CRLF and cause errors in test.

I'm not familiar with test, should the fix convert those 3 files to LF or remove this test?
@k-yle k-yle mentioned this issue Jan 3, 2025
Merged
@k-yle
Copy link
Collaborator

k-yle commented Jan 3, 2025

You could disable git's autocrlf for this repo, or globally. But once #10647 is merged, it won't matter what git settings you use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use LF line endings for .mjs files openstreetmap/iD
2 participants
@k-yle @Nekzuris