Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapillary: Generic detections #10500

Open
danieldegroot2 opened this issue Oct 15, 2024 · 2 comments
Open

Mapillary: Generic detections #10500

danieldegroot2 opened this issue Oct 15, 2024 · 2 comments
Labels
bug-cant-reproduce Having trouble reproducing this issue

Comments

@danieldegroot2
Copy link
Contributor

danieldegroot2 commented Oct 15, 2024

URL

No response

How to reproduce the issue?

Moved from #9874

Originally posted by danieldegroot2 August 29, 2023
This may be broken for me. It seems some detections do not have an icon and some may return a missing translation error.
I have also no idea how to check the web console for these elements as they can't be right clicked.

Sidenote: RapiD does not seem to show these empty icons.

Screenshot(s) or anything else?

For https://www.openstreetmap.org/edit#map=20/52.65018/-7.24964

'General directions' sign detection at https://www.mapillary.com/app/?pKey=137639318388569&focus=photo

image

image


Translation errors
image

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Chrome

@tyrasd
Copy link
Member

tyrasd commented Dec 17, 2024

I wasn't able to reproduce the issue today. It could be that the problem was fixed somewhere upstream in the meantime. If you're still getting the issue: can you share the exact coordinates where the missing icons are "not rendered", please?

@tyrasd tyrasd added the bug-cant-reproduce Having trouble reproducing this issue label Dec 17, 2024
@danieldegroot2 danieldegroot2 changed the title Mapillary: Some detection icons are missing Mapillary: Generic detections Dec 17, 2024
@danieldegroot2
Copy link
Contributor Author

2.31.0-dev, Chrome 131.0.6778.140 on Windows 10.
https://ideditor.netlify.app/#background=EsriWorldImageryClarity&disable_features=boundaries&map=20.12/52.65020/-7.24939&photo_overlay=mapillary,mapillary-map-features,mapillary-signs
image

RapiD 2.4.3 shows this object as (fallback?) question mark icon
https://rapideditor.org/edit#map=20.12/52.65020/-7.24933/1.1&background=EsriWorldImagery&datasets=fbRoads,msBuildings&disable_features=boundaries
image

Mapillary shows this one with an orange outline, no text label, can't be clicked. It is not shown on the map at all.
image


RapiD shows some others with question mark icon for miscellaneous objects 'Other' category
image


I would suggest either showing all generic detections with a question mark icon, or hiding them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-cant-reproduce Having trouble reproducing this issue
Projects
None yet
Development

No branches or pull requests

2 participants