Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging two ways corrupts step_count #10492

Open
danieldegroot2 opened this issue Oct 10, 2024 · 4 comments
Open

Merging two ways corrupts step_count #10492

danieldegroot2 opened this issue Oct 10, 2024 · 4 comments
Labels
good first issue Best for first-time contributors. No experience necessary!

Comments

@danieldegroot2
Copy link
Contributor

URL

No response

How to reproduce the issue?

Follow-up to #8069

Splitting a way in two results in i.e. step count of 4 => 3+1 / 2+2 depending on the length of the way itself.
However, merging two ways will result in 3+1 => Error (values are not the same), or 2+2 => 2 (merged, values are not summed)
Perhaps summing up the values, or alternatively (prompting to) delete the values (if situation has changed significantly), is better.

See also MarcusWolschon/osmeditor4android#1251 (comment)

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Chrome

@1ec5
Copy link
Collaborator

1ec5 commented Oct 11, 2024

A similar issue is merging ways tagged parking:left/right/both:capacity=*. Summing the values sounds reasonable to me, though this assumes that the preexisting split doesn’t correspond to the location of one of the steps being counted twice. Refusing to merge also seems OK, though it would be annoying to the user without clear guidance on how to resolve the conflict.

@1ec5 1ec5 added the good first issue Best for first-time contributors. No experience necessary! label Oct 15, 2024
@haresahani
Copy link

I’d like to work on this issue. Could you assign it to me?

@Deeptanshu-sankhwar
Copy link
Contributor

Hey @haresahani , kindly let me know if you're still working on it.

@Darshit42
Copy link

@Deeptanshu-sankhwar , @haresahani anyone of you working on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary!
Projects
None yet
Development

No branches or pull requests

5 participants