From 5f77b5f1ce2f68f24e63773bb1c33797e8e3ee55 Mon Sep 17 00:00:00 2001 From: jgilaber Date: Fri, 29 Nov 2024 11:26:13 +0100 Subject: [PATCH] Disable some rules for crd schema check NoFieldRemoval and NoNewRequiredFields need to be temporarily disabled since we're currently building the crds as we go. ConditionsMustHaveProperSSATags and ListsMustHaveSSATags are disabled beacuse they affect the Conditions type defined in lib-common, so they are not specific to watcher-operator. --- hack/crd-schema-checker.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/hack/crd-schema-checker.sh b/hack/crd-schema-checker.sh index c431ae5..191e60b 100755 --- a/hack/crd-schema-checker.sh +++ b/hack/crd-schema-checker.sh @@ -17,5 +17,6 @@ for crd in config/crd/bases/*.yaml; do git show "$BASE_REF:$crd" > "$TMP_DIR/$crd" $CHECKER check-manifests \ --existing-crd-filename="$TMP_DIR/$crd" \ + --disabled-validators="NoFieldRemoval,NoNewRequiredFields,ConditionsMustHaveProperSSATags,ListsMustHaveSSATags" \ --new-crd-filename="$crd" done