Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pre-commit with make #79

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Run pre-commit with make #79

merged 1 commit into from
Mar 27, 2023

Conversation

amolkahat
Copy link
Contributor

Updating pre-commit hook with make. pre-commit-golang repo is no longer maintained[1]. Instead of using
unmaintained repo we can use make to run pre-commit.

[1] dnephin/pre-commit-golang#98

@openshift-ci openshift-ci bot requested review from stuggi and viroel February 22, 2023 09:57
@amolkahat
Copy link
Contributor Author

/test mariadb-operator-build-deploy-kuttl

@amolkahat
Run pre-commit with make
7cc258d 
Updating pre-commit hook with make. pre-commit-golang
repo is no longer maintained. Instead of using
unmaintained repo we can use make to run pre-commit.

Signed-off-by: Amol Kahat <[email protected]>
@amolkahat
Copy link
Contributor Author

Results

akahat@jatayu mariadb-operator $ pre-commit run -a
golangci-lint............................................................Passed
golint...................................................................Passed
gofmt....................................................................Passed
govet....................................................................Passed
gotidy...................................................................Passed
make-manifests...........................................................Passed
make-generate............................................................Passed
make-operator-lint.......................................................Passed
check for added large files..............................................Passed
fix utf-8 byte order marker..............................................Passed
check for case conflicts.................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for merge conflicts................................................Passed
check for broken symlinks................................................Passed
detect destroyed symlinks................................................Passed
check yaml...............................................................Passed
check json...............................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
don't commit to branch...................................................Passed
trim trailing whitespace.................................................Passed
bashate..................................................................Passed

akahat@jatayu mariadb-operator $

@amolkahat
Copy link
Contributor Author

/test mariadb-operator-build-deploy-kuttl

@amolkahat amolkahat mentioned this pull request Mar 27, 2023
Closed
abays
abays approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, amolkahat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9b37cd8 into openstack-k8s-operators:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandeepyadav93 Sandeepyadav93 Sandeepyadav93 requested changes

@abays abays abays approved these changes

@stuggi stuggi Awaiting requested review from stuggi

@viroel viroel Awaiting requested review from viroel

Assignees

@abays abays

@Sandeepyadav93 Sandeepyadav93

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amolkahat @abays @Sandeepyadav93 @openshift-merge-robot