Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_GeometryPath as a wrapper function for getGeometryPath in OpenSim 4.5 #3732

Closed
cvhammond opened this issue Mar 7, 2024 · 4 comments

Comments

@cvhammond
Copy link
Member

It seems that OpenSim 4.5 has removed get_GeometryPath() from the core library and associated MATLAB wrapper. Can you please add get_GeometryPath() as a wrapper for getGeometryPath() so as to ensure backwards compatibility for anyone who is migrating from OpenSim 4.4 to OpenSim 4.5?

@tkuchida
Copy link
Member

tkuchida commented Mar 7, 2024

(See PR #3535 and upgrade notes for v4.5 in CHANGELOG.md.)

@nickbianco
Copy link
Member

Hi @cvhammond, getGeometryPath() is compatible with both OpenSim 4.4 and 4.5.

The get_ syntax is typically reserved for property methods, the unnamed property GeometryPath was removed in favor of the named property path of type AbstractGeometryPath. See the PR linked above for more details.

@nickbianco
Copy link
Member

nickbianco commented Mar 7, 2024

I added a note to the OpenSim 4.5 release notes on Confluence.

@nickbianco
Copy link
Member

@cvhammond, thanks again for bringing this up, but since we do have the backwards compatible option we do not plan to add this wrapper for the reasons stated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants