Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Next Theme) Reporting needs a Print mode for dark mode compatibility #735

Open
2 tasks
Tracked by #895
KrooshalUX opened this issue Jul 27, 2023 · 4 comments
Open
2 tasks
Tracked by #895
Assignees

Comments

@KrooshalUX
Copy link

KrooshalUX commented Jul 27, 2023

This issue to be transferred to corresponding repository

I am working on launching new light and dark mode themes provided by OUI component library for a target launch within 2.10. These changes support the vision expressed in Future Vision for Dashboards

I have identified the following front end related issues that prevent the theme from appearing complete and potential solutions within this feature:

  • When in dark mode, the report is generated using dark mode panel backgrounds, but light mode page background
  • Font overrides are present in collapsible nav (left application navigation) as well as visualization panels

Screen Shot 2023-07-27 at 12 09 15 PM

@wbeckler wbeckler transferred this issue from opensearch-project/oui Jul 27, 2023
@anirudha
Copy link
Collaborator

Reporting should be light mode only. Save ink ;) imho.

We would need a runtime flag to ensure dashboards can be always light mode instead of changing settings. Eg. A get or post parameter

@anirudha
Copy link
Collaborator

The bug seems like a css rendering issue in dashboards. Needs investigating

@wbeckler wbeckler changed the title (OUI Next Theme) Reporting (OUI Next Theme) Reporting needs a Print mode for dark mode compatibility Aug 3, 2023
@derek-ho derek-ho removed the untriaged label Aug 3, 2023
@derek-ho
Copy link
Collaborator

derek-ho commented Aug 3, 2023

@rupal-bq temporarily assigning to you until we figure out how to divide up these tasks - seems like a lot of OUI compliance issues coming our way

@AMoo-Miki
Copy link

My PR addresses Part 1 and removes the side menu, it doesn't address the second part of this issue.

The problem is that the library intentionally doesn't copy the stylesheets and hence doesn't get the font definitions. So even though the elements are asking for the right font-family, since they don't know where to find them, the system fonts are used. This is not only a visual problem but also leads to clipped texts and resized elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants