From 21ca56ad0757bffaa14fa313bba79fd00d11df9e Mon Sep 17 00:00:00 2001
From: Brandon Shien <44730413+bshien@users.noreply.github.com>
Date: Tue, 25 Jun 2024 14:27:55 -0700
Subject: [PATCH] Changed Canary alarm threshold from 100 to 50 (#44)

Signed-off-by: Brandon Shien <bshien@amazon.com>
---
 infrastructure/lib/constructs/canarySns.ts   |  2 +-
 infrastructure/package-lock.json             | 21 ++++++++++----------
 infrastructure/test/monitoring-stack.test.ts |  2 +-
 3 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/infrastructure/lib/constructs/canarySns.ts b/infrastructure/lib/constructs/canarySns.ts
index a9fa1bd..766be9a 100644
--- a/infrastructure/lib/constructs/canarySns.ts
+++ b/infrastructure/lib/constructs/canarySns.ts
@@ -25,7 +25,7 @@ export class canarySns extends SnsMonitors {
     private canaryFailed(alertName: string, canary: Canary): [Alarm, string] {
         const alarmObject = new cloudwatch.Alarm(this, `error_alarm_${alertName}`, {
             metric: canary.metricSuccessPercent(),
-            threshold: 100,
+            threshold: 50,
             evaluationPeriods: 1,
             comparisonOperator: cloudwatch.ComparisonOperator.LESS_THAN_THRESHOLD,
             datapointsToAlarm: 1,
diff --git a/infrastructure/package-lock.json b/infrastructure/package-lock.json
index 2cfd42d..402e605 100644
--- a/infrastructure/package-lock.json
+++ b/infrastructure/package-lock.json
@@ -1720,12 +1720,12 @@
       }
     },
     "node_modules/braces": {
-      "version": "3.0.2",
-      "resolved": "https://registry.npmjs.org/braces/-/braces-3.0.2.tgz",
-      "integrity": "sha512-b8um+L1RzM3WDSzvhm6gIz1yfTbBt6YTlcEKAvsmqCZZFw46z626lVj9j1yEPW33H5H+lBQpZMP1k8l+78Ha0A==",
+      "version": "3.0.3",
+      "resolved": "https://registry.npmjs.org/braces/-/braces-3.0.3.tgz",
+      "integrity": "sha512-yQbXgO/OSZVD2IsiLlro+7Hf6Q18EJrKSEsdoMzKePKXct3gvD8oLcOQdIzGupr5Fj+EDe8gO/lxc1BzfMpxvA==",
       "dev": true,
       "dependencies": {
-        "fill-range": "^7.0.1"
+        "fill-range": "^7.1.1"
       },
       "engines": {
         "node": ">=8"
@@ -2276,9 +2276,9 @@
       }
     },
     "node_modules/fill-range": {
-      "version": "7.0.1",
-      "resolved": "https://registry.npmjs.org/fill-range/-/fill-range-7.0.1.tgz",
-      "integrity": "sha512-qOo9F+dMUmC2Lcb4BbVvnKJxTPjCm+RRpe4gDuGrzkL7mEVl/djYSu2OdQ2Pa302N4oqkSg9ir6jaLWJ2USVpQ==",
+      "version": "7.1.1",
+      "resolved": "https://registry.npmjs.org/fill-range/-/fill-range-7.1.1.tgz",
+      "integrity": "sha512-YsGpe3WHLK8ZYi4tWDg2Jy3ebRz2rXowDxnld4bkQB00cc/1Zw9AWnC0i9ztDJitivtQvaI9KaLyKrc+hBW0yg==",
       "dev": true,
       "dependencies": {
         "to-regex-range": "^5.0.1"
@@ -3867,6 +3867,7 @@
       "version": "2.3.1",
       "resolved": "https://registry.npmjs.org/punycode/-/punycode-2.3.1.tgz",
       "integrity": "sha512-vYt7UD1U9Wg6138shLtLOvdAu+8DsC/ilFtEVHcH+wydcSpNE20AfSOduf6MkRFahL5FY7X1oU7nKVZFtfq8Fg==",
+      "dev": true,
       "engines": {
         "node": ">=6"
       }
@@ -4635,9 +4636,9 @@
       }
     },
     "node_modules/ws": {
-      "version": "7.5.9",
-      "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.9.tgz",
-      "integrity": "sha512-F+P9Jil7UiSKSkppIiD94dN07AwvFixvLIj1Og1Rl9GGMuNipJnV9JzjD6XuqmAeiswGvUmNLjr5cFuXwNS77Q==",
+      "version": "7.5.10",
+      "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.10.tgz",
+      "integrity": "sha512-+dbF1tHwZpXcbOJdVOkzLDxZP1ailvSxM6ZweXTegylPny803bFhA+vqBYw4s31NSAk4S2Qz+AKXK9a4wkdjcQ==",
       "dev": true,
       "engines": {
         "node": ">=8.3.0"
diff --git a/infrastructure/test/monitoring-stack.test.ts b/infrastructure/test/monitoring-stack.test.ts
index d609ba1..99826a3 100644
--- a/infrastructure/test/monitoring-stack.test.ts
+++ b/infrastructure/test/monitoring-stack.test.ts
@@ -226,7 +226,7 @@ test('Monitoring Stack Test', () => {
         "Namespace": "CloudWatchSynthetics",
         "Period": 300,
         "Statistic": "Average",
-        "Threshold": 100,
+        "Threshold": 50,
         "TreatMissingData": "notBreaching"
     });
 });