Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Manifest workflow failed due to increase of minimumCompileVersion of Java update in 2.x #4952

Closed
peterzhuamazon opened this issue Aug 19, 2024 · 6 comments · Fixed by #4953, #4954 or #4957
Assignees
Labels

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Aug 19, 2024

opensearch-project/OpenSearch@399c646

This has triggered a wave of failure in manifest-update workflow specifically on OpenSearch 2.x branch.

Starting here: https://build.ci.opensearch.org/job/manifest-update/506/console


PRs:

@prudhvigodithi
Copy link
Member

Looks to me like an issue with jdk11 coming from https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/manifests-update.jenkinsFile#L25?
Because the ./gradlew properties -Dbuild.snapshot=false for OpenSearch 2.x works on my local with jdk21 and for jdk11 I get an error * What went wrong: Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0, the same shows in the build log https://build.ci.opensearch.org/job/manifest-update/506/console.

@reta
Copy link
Contributor

reta commented Aug 19, 2024

@peterzhuamazon @prudhvigodithi Gradle 8.10 deprecated usage of any JDK lower than JDK-16. We need to use JDK-17 for manifest builds.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Aug 19, 2024

Seems like that build dep and runtime dep is using different version now.

Runtime dep min is still 11: https://opensearch.org/docs/latest/install-and-configure/install-opensearch/index/#java-compatibility

Build time dep min is now 17 minimum: opensearch-project/OpenSearch#15267

@reta
Copy link
Contributor

reta commented Aug 19, 2024

Yes, it could be extracted from minimumCompilerVersion file

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Aug 20, 2024

Re-open as it is not fixed permanently as of now.

Pending review:

@peterzhuamazon peterzhuamazon moved this from Not started to In Progress in OpenSearch Engineering Effectiveness Aug 20, 2024
@peterzhuamazon peterzhuamazon added enhancement New Enhancement and removed untriaged Issues that have not yet been triaged labels Aug 20, 2024
@peterzhuamazon peterzhuamazon changed the title [BUG] Manifest workflow failed due to lower gradle version update in 2.x [BUG] Manifest workflow failed due to increase of minimumCompileVersion of Java update in 2.x Aug 20, 2024
@peterzhuamazon
Copy link
Member Author

Not fully fixed. Still have issues.

@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Engineering Effectiveness Board Aug 20, 2024
@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label Aug 20, 2024
@peterzhuamazon peterzhuamazon removed the untriaged Issues that have not yet been triaged label Aug 20, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Engineering Effectiveness Board Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment