[Bug]: Version bump PR for functional test repo failed to update pack-lock.json

[zelinh]

Describe the bug

The auto-generated version bump PR for functional test repo didn't include package-lock.json file.
e.g. opensearch-project/opensearch-dashboards-functional-test#1216

It should have increment the version in package-lock.json here https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/45396abd554474e1eca18f20bb77bf42ee11fafa/package-lock.json#L3
along with package.json.

Seems like we missed it here.

opensearch-build/.github/workflows/osd-increment-plugin-versions.yml

Lines 95 to 99 in 90352da

	elif [ ${{ matrix.entry.repo }} == "opensearch-dashboards-functional-test" ]; then
	jq --arg DASHBOARD_VERSION "${{ env.DASHBOARD_VERSION }}" '.version = $DASHBOARD_VERSION' package.json > package-tmp.json
	mv package-tmp.json package.json
	OSD_PLUGIN_VERSION=$(node -p "require('./package.json').version")
	echo "OSD_PLUGIN_VERSION=$OSD_PLUGIN_VERSION" >> $GITHUB_ENV

To reproduce

Run the current GHA Increment OpenSearch Dashboards Plugins Version

Expected behavior

All two json files should have version incremented.

[prudhvigodithi]

Hey @zelinh that is done on purpose as AFAIK for FT repo we dont package-lock.json file, here are some sample old PR's that only increments package.json
https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1206/files
opensearch-project/opensearch-dashboards-functional-test#1121
Adding @AMoo-Miki to confirm.

@bbarani @Divyaasm

[AMoo-Miki]

Yeah; we shouldn't need to bump it but it could help with tracking if we ever need to do so (which we have never needed to).

[rishabh6788]

Do we have a consensus on whether it should or should not be included? @AMoo-Miki

[AMoo-Miki]

Thinking about it more, we should keep the versions in the lock file and the manifest in sync.

[prudhvigodithi]

There is some discussion in past #3856 related to yarn.lock file. If just adding package-lock.json is required then:

• Ensure that the lock file is updated as part of the version increment plugin helper (node ../../scripts/plugin_helpers version).
• Add the file to git commit https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/osd-increment-plugin-versions.yml#L193.

Thank you
@peterzhuamazon @getsaurabh02

[Divyaasm]

The package-lock.json is not being updated currently check here. Do we still need to automate this?