Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Evict graphs from cache when index is closed or delete for indices that are created using NativeEngines990KnnVectorsFormat #2148

Closed
VijayanB opened this issue Sep 25, 2024 · 3 comments

Comments

@VijayanB
Copy link
Member

Is your feature request related to a problem?
This PR #1946 clears graph from cache whenever index is closed or deleted to save memory. However this works only for indices created using BinaryDocValues. With 2.17. k-NN uses NativeEngines990KnnVectorsFormat, hence, we need similar feature for indices that are created using this new format.

What solution would you like?
Evict graph when index is closed or deleted irrespective of vector format.

What alternatives have you considered?
N/A

Do you have any additional context?
N/A

@VijayanB VijayanB changed the title [FEATURE] Evict graphs from cache when index is closed for indices are created using NativeEngines990KnnVectorsFormat [FEATURE] Evict graphs from cache when index is closed or delete for indices that are created using NativeEngines990KnnVectorsFormat Sep 25, 2024
@vamshin vamshin added v2.18.0 and removed untriaged labels Sep 27, 2024
@navneet1v navneet1v moved this from Backlog to Backlog (Hot) in Vector Search RoadMap Oct 2, 2024
@navneet1v
Copy link
Collaborator

@0ctopus13prime do you want to pick this task up as part of removing the file watcher dependency from k-NN plugin?

@0ctopus13prime
Copy link
Contributor

@navneet1v
Hi Navneet! Sorry, I just saw your comment.
And as you know, the related PR was merged for both main and 2.x, I think we can close this out!

@navneet1v
Copy link
Collaborator

Closing out this issue after getting confirmation from @0ctopus13prime

@github-project-automation github-project-automation bot moved this from Backlog (Hot) to ✅ Done in Vector Search RoadMap Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants