Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DeleteModelStep and DeleteAgentStep don't handle NOT_FOUND exceptions #803

Closed
dbwiddis opened this issue Jul 25, 2024 · 0 comments · Fixed by #805
Closed

[BUG] DeleteModelStep and DeleteAgentStep don't handle NOT_FOUND exceptions #803

dbwiddis opened this issue Jul 25, 2024 · 0 comments · Fixed by #805
Labels
bug Something isn't working untriaged v2.16.0 Issues targeting release v2.16.0

Comments

@dbwiddis
Copy link
Member

What is the bug?

When deleting a connector, the Delete action is called directly without checking for existence of the connector; the DeleteResponse includes a DocWriteReponse.NOT_FOUND specifically to handle this use case.

However, for deleting models and deleting agents, ML Commons does a Get first (to check for various other reasons we can not delete) and in the case of the model/agent not being found, throws an exception instead.

Thus it is impossible to deprovision a model or agent that does not exist.

How can one reproduce the bug?

  1. Provision a workflow that creates a model and/or agent.
  2. Manually delete the model and/or agent with ML Commons API
  3. Attempt to deprovision the workflow.

What is the expected behavior?

NOT_FOUND is not an error when deleting, and the resource is removed.

@dbwiddis dbwiddis added bug Something isn't working untriaged v2.16.0 Issues targeting release v2.16.0 labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged v2.16.0 Issues targeting release v2.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant