Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] [Star Tree] Option/Param to Disable search via star-tree #14872

Closed
sandeshkr419 opened this issue Jul 22, 2024 · 2 comments
Closed

[Search] [Star Tree] Option/Param to Disable search via star-tree #14872

sandeshkr419 opened this issue Jul 22, 2024 · 2 comments
Labels
Search Search query, autocomplete ...etc

Comments

@sandeshkr419
Copy link
Contributor

sandeshkr419 commented Jul 22, 2024

This issue is a follow-up on #14871

This change concerns indices that support star-tree, and the query/aggregation can be resolved via star-tree. The default search implementation should always use the star-tree if possible for faster query/aggregation support. However, a user should have capability to search via previous non-startree implementation.

One way could be to pass a parameter in search request itself like disable_startree_search: true in search request to skip star-tree execution of a request.

In that way a user can utilize the old code flow without having to get rid of the star-tree from their index or making any changes to the index. In this way, any potential bugs in star-tree index will not affect the user from performing their desired operation with no extra effort.

Alternative is to have cluster level setting, but that takes away the granularity. Or we can have both in place.

@mgodwan
Copy link
Member

mgodwan commented Jul 23, 2024

  1. What are the use-cases where we may want to allow users to choose this?
  2. In case of handling issues like regression, it should be a cluster level setting instead (but even that should be a decision OpenSearch takes by doing a cost estimation for running the query).

@mch2 mch2 removed the untriaged label Jul 24, 2024
@sandeshkr419
Copy link
Contributor Author

Discussed the above in Search triage meetup. The was a consensus on not having this param at the request level in sync with @mgodwan comments. Closing this issue for now.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Aug 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Performance Roadmap Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search Search query, autocomplete ...etc
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants