Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] org.opensearch.indices.IndicesRequestCacheIT.testProfileDisableCache is flaky #11374

Closed
reta opened this issue Nov 28, 2023 · 7 comments
Closed
Assignees
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search:Performance Search:Relevance Search:Resiliency Search Search query, autocomplete ...etc

Comments

@reta
Copy link
Collaborator

reta commented Nov 28, 2023

Describe the bug
The test case org.opensearch.indices.IndicesRequestCacheIT.testProfileDisableCache {p0={"search.concurrent_segment_search.enabled":"true"}} is flaky:

org.opensearch.indices.IndicesRequestCacheIT.testProfileDisableCache {p0={"search.concurrent_segment_search.enabled":"true"}}

java.lang.AssertionError: expected:<[1, 1, 0]> but was:<[0, 2, 0]>
	at __randomizedtesting.SeedInfo.seed([5507014708D300D0:F76E1CAB764B5B4E]:0)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at org.opensearch.indices.IndicesRequestCacheIT.assertCacheState(IndicesRequestCacheIT.java:649)
	at org.opensearch.indices.IndicesRequestCacheIT.testProfileDisableCache(IndicesRequestCacheIT.java:635)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at java.base/java.lang.Thread.run(Thread.java:1583)

To Reproduce

: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.IndicesRequestCacheIT" -Dtests.method="testProfileDisableCache {p0={"search.concurrent_segment_search.enabled":"true"}}" 

Expected behavior
The test should always pass

Plugins
Standard

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • CI

Additional context

@reta reta added bug Something isn't working untriaged flaky-test Random test failure that succeeds on second run labels Nov 28, 2023
@peternied peternied added Search Search query, autocomplete ...etc Search:Resiliency Search:Relevance and removed untriaged labels Nov 30, 2023
@peternied peternied added Indexing & Search Indexing Indexing, Bulk Indexing and anything related to indexing Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Nov 30, 2023
@peternied
Copy link
Member

Thanks for filing this issue

@neetikasinghal
Copy link
Contributor

I am not able to reproduce this in 500 runs yet.

@neetikasinghal
Copy link
Contributor

Unable to reproduce it within 2000 runs as well. Also tried with the random seed mentioned in the build failure above.

@neetikasinghal
Copy link
Contributor

Unable to reproduce this within 3500 runs, I will close this issue for now. We can re-open it back if encounter this failure back.

@jed326
Copy link
Collaborator

jed326 commented Mar 27, 2024

This looks like the same category as #12308.
The failure here doesn't look related to concurrent search, @sgup432 mind taking a look at this one to see if it's related to the pluggable caching changes?

@mgodwan mgodwan removed Indexing & Search Indexing Indexing, Bulk Indexing and anything related to indexing Indexing:Replication Issues and PRs related to core replication framework eg segrep labels May 15, 2024
andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
andrross added a commit that referenced this issue Jun 7, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600

Signed-off-by: Andrew Ross <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 7, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit fbe048f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this issue Jun 10, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600


(cherry picked from commit fbe048f)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this issue Jun 10, 2024
@kiranprakash154 kiranprakash154 self-assigned this Jun 12, 2024
@reta
Copy link
Collaborator Author

reta commented Jun 19, 2024

Closing in favour of #14288

@reta reta closed this as completed Jun 19, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Search Project Board Jun 19, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this issue Jul 24, 2024
…opensearch-project#14082)

These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

(cherry picked from commit fbe048f)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this issue Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search:Performance Search:Relevance Search:Resiliency Search Search query, autocomplete ...etc
Projects
Status: Done
Development

No branches or pull requests

8 participants