Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor coding system and mapping Downloader classes #2244

Open
Jongmassey opened this issue Dec 13, 2024 · 0 comments
Open

Refactor coding system and mapping Downloader classes #2244

Jongmassey opened this issue Dec 13, 2024 · 0 comments
Labels
deck-scrubbing Tech debt or other between-initiative tidy-up work

Comments

@Jongmassey
Copy link
Contributor

Following this comment on a PR review.

The bnf to dmd mapping downloader was based on the TrudDownloader class used by the dm+d and SNOMED CT coding systems for reasons of expediency and the ease of integrating it into the scheduled download scripts used by the latter.

It was pointed out in the review that this reimplementation and the original class could be refactored to change methods that are currently instance methods to static methods and remove some duplicated code.

These both could be further refactored into a common ancestor to further reduce duplication.

@Jongmassey Jongmassey added the deck-scrubbing Tech debt or other between-initiative tidy-up work label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deck-scrubbing Tech debt or other between-initiative tidy-up work
Projects
None yet
Development

No branches or pull requests

1 participant