Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root cause of error lost when retried. #2365

Open
bloodearnest opened this issue Jan 21, 2025 · 0 comments
Open

Root cause of error lost when retried. #2365

bloodearnest opened this issue Jan 21, 2025 · 0 comments

Comments

@bloodearnest
Copy link
Member

The retry logic will attempt to retry a failed db operation.

However, it does not currently preserve the original exception that caused the operation to be retried. The code that walks the exception tree to detect certain errors will then always default to the fail-through exit code of 5, rather than the specific error codes for certain known errors. This ends up having misleading messaging to users about why their jobs failed, and more tech support.

We should probably try an include the original exception in the exception tree, by passing it to the retry logic, and raise the final error from original_exception. This is both technically correct, and the existing code should work with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant