Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show output checking requests on a separate page to user's own requests #702

Open
inglesp opened this issue Oct 23, 2024 · 0 comments
Open
Assignees

Comments

@inglesp
Copy link
Contributor

inglesp commented Oct 23, 2024

From @LFISHER7:

As an output checker going to the requests page, the first thing you see is your personal requests, which if i'm visiting as an output checker I don't care about. I'd prefer to have a page where, as a researcher you can see your workspaces and your requests and then a separate page for output checkers where you just see any open requests.

Implementation notes

  • In airlock/views/request.py, create two new view functions to replace request_index. One should be called requests_for_researcher and the other should be called requests_for_output_checker.
  • requests_for_researcher should pass the results of calling bll.get_requests_authored_by_user() to a new template (requests_for_researcher.html), which should only contain the relevant parts of requests.html.
  • requests_for_output_checker should first check that the user is an output checker (via permissions.user_can_review(request.user)) and raise PermissionDenied if not. If the user is an output checker, it should calculate outstanding_requests, returned_requests, and approved_requests, and pass these to a new template (requests_for_output_checker.html), which should only contain the relevant parts of requests.html.
  • In airlock/urls.py, add two new patterns for these two new view functions.
  • In airlock/urls.py, add a redirect from "requests/" to the new requests_for_researcher view.
  • Having done this, we should get input from users (including @LFISHER7) about how to navigate to these new pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants