Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concatenation with empty string is not parsed idempotently #126

Open
greg-at-moderne opened this issue Jan 15, 2025 · 0 comments
Open

Concatenation with empty string is not parsed idempotently #126

greg-at-moderne opened this issue Jan 15, 2025 · 0 comments
Labels
bug Something isn't working parser-python

Comments

@greg-at-moderne
Copy link
Contributor

Steps to reproduce

Using current main (da16633) the following test:

def test_concatenation_with_empty_string():
  # language=python
  rewrite_run(python('print("alef" "")'))

fails with:

Expected :'print("alef" "")'
Actual   :'print("alef" )'

AFAICT this is valid Python code.
@greg-at-moderne greg-at-moderne added bug Something isn't working parser-python labels Jan 15, 2025
@timtebeek timtebeek moved this to Backlog in OpenRewrite Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working parser-python
Projects
OpenRewrite
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greg-at-moderne