Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HttpRequest as a second type parameter to implementations of io.micronaut.views.ViewsRenderer. #86

Open
jeremyg484 opened this issue Jul 19, 2023 · 0 comments
Open

Add HttpRequest as a second type parameter to implementations of io.micronaut.views.ViewsRenderer. #86

jeremyg484 opened this issue Jul 19, 2023 · 0 comments
Assignees
@jeremyg484
Labels
recipe Recipe requested
Milestone
Micronaut 4.0

Comments

@jeremyg484
Copy link
Collaborator

Existing Micronaut Framework 3 custom implementations of io.micronaut.views.ViewsRenderer will need to have HttpRequest as the second type parameter of the interface in their implements clause.

See https://github.com/micronaut-projects/micronaut-views/pull/522/files#diff-53c8c42976226a75e3ff1aacc22c53fac34b5f38ecc88b036a611a232791fe06 for the interface changes.

This is a continuation of the changes noted in issue #63
@jeremyg484 jeremyg484 added the recipe Recipe requested label Jul 19, 2023
@jeremyg484 jeremyg484 added this to the Micronaut 4.0 milestone Jul 19, 2023
@jeremyg484 jeremyg484 self-assigned this Jul 19, 2023
@timtebeek timtebeek moved this to Recipes Wanted in OpenRewrite Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremyg484 jeremyg484

Labels
recipe Recipe requested
Projects
OpenRewrite
Status: Recipes Wanted
Milestone
Micronaut 4.0
Development

No branches or pull requests
1 participant
@jeremyg484