-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for org.openrewrite.java.style.ImportLayoutStyle.layout #253
Comments
Hi @MartinAhrer , good seeing you here! Indeed seems like an area we haven't covered with our docs yet; thanks for pointing that out and providing an example. Perhaps we could work that into our page on Styles @mike-solomon ? rewrite-docs/concepts-and-explanations/styles.md Lines 13 to 15 in d8505db
|
Hey there @MartinAhrer -- I'm taking a look at this issue now, but I'm a bit confused. Hoping you might be able to help me understand the issue. Were you trying to define your style declaratively in YAML? In taking a look at the schema, I don't see any Is the issue that Thanks for your time! |
Maybe you could even share the style yaml you arrived at, such that we can include it both in the docs and the json schema we have, if you're open to that. |
Yes, I was trying to do that using YML. Here is a more complete example:
However import formatting didn't work as expected and was only correct partially. And this was the reason for requesting a more comprehensive documentation on that configuration. |
What problem are you trying to solve?
Implementing a style for formatting (rearranging) Java import statements
Describe the solution you'd like
Add documentation and examples showing how the layout property's list elements need to look like.
Have you considered any alternatives or workarounds?
It was only possible to figure out the format of a layout list element by reading the source code for
org.openrewrite.java.style.Deserializer
.Example:
The text was updated successfully, but these errors were encountered: