Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: nexrad level2 time and missing elevations #181

Merged
merged 6 commits into from
Aug 1, 2024
Merged

FIX: nexrad level2 time and missing elevations #181

merged 6 commits into from
Aug 1, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Jul 30, 2024 •
edited
Loading

@kmuehlbauer
Copy link
Collaborator Author

kmuehlbauer commented Jul 30, 2024 •
edited
Loading

@ghiggi I've tracked down the other issue.

There is some radial status of 5 which we need to take into account as a new start of a sweep (final sweep in VCP) and there are elevations missing in the data file although they are advertised in message 5. Not sure what's going on there.

@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (44df4e4) to head (07c8db0).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
xradar/io/backends/nexrad_level2.py 90.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   91.81%   91.77%   -0.04%     
==========================================
  Files          23       23              
  Lines        4519     4524       +5     
==========================================
+ Hits         4149     4152       +3     
- Misses        370      372       +2
Flag Coverage Δ
notebooktests 78.22% <90.00%> (-0.03%) ⬇️
unittests 90.03% <90.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiggi
Copy link

ghiggi commented Jul 30, 2024 •
edited
Loading

Cool @kmuehlbauer ! Thanks to have solved this.
I guess that for the end of next week, on my side, I can make a new release of gpm-api with an in-depth tutorial on how to perform SR/GR calibration "on-the-fly" using xradar and various radar datasets available on S3 (nexrad, columbian and fmi). I will ping you when ready and then we can discuss what to use for the ERAD short course ;)

@kmuehlbauer
Copy link
Collaborator Author

I think this is good to go. I'll merge tomorrow, if no one beats me to it.

@mgrover1
Copy link
Collaborator

This looks great! Good to merge!

@mgrover1
Copy link
Collaborator

mgrover1 commented Aug 1, 2024

@kmuehlbauer - is it okay if I go ahead and merge? This looks great!

@kmuehlbauer
Copy link
Collaborator Author

Oh my, I thought I've pressed the merge button already. Yes, please go ahead!

@mgrover1 mgrover1 merged commit 1fca580 into openradar:main Aug 1, 2024
17 of 18 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-nexrad-level2 branch August 1, 2024 13:58
rcjackson pushed a commit to rcjackson/xradar that referenced this pull request Aug 23, 2024
@kmuehlbauer @rcjackson
FIX: nexrad level2 time and missing elevations (openradar#181)
a64aa1c 
* FIX: time issue due to 1-based day count

* FIX: restructure retrieval of msg_31, do not try to read missing elevations, even when listed in msg_5

* add history.md entry

* add comment on radial_status 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs in NEXRAD L2 reader
3 participants
@kmuehlbauer @ghiggi @mgrover1