Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Coverage #156

Open
2 of 4 tasks
kmuehlbauer opened this issue Feb 28, 2024 · 0 comments
Open
2 of 4 tasks

Code Coverage #156

kmuehlbauer opened this issue Feb 28, 2024 · 0 comments

Comments

@kmuehlbauer
Copy link
Collaborator

kmuehlbauer commented Feb 28, 2024 •
edited
Loading

Currently we have roughly 90% code coverage.

While this seems good, much of that coverage is generated by reading files and checking some data of that files. This might give a wrong impression.

My suggestion is:

  • split the current unit-tests into real unit-tests and filecheck-tests to separate these two wrt to code coverage
  • bring unit-tests to 100% by adding tests (as much as possible)
  • fix notebook-tests to also create coverage report (currently broken: CoverageWarning: No data was collected. (no-data-collected)) MNT: fix path for notebook coverage #157
  • use codecov token MNT: use CODECOV token #155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmuehlbauer