Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional breaks fail at grace notes #2

Open
mrtnnbr opened this issue Feb 4, 2020 · 2 comments
Open

Conditional breaks fail at grace notes #2

mrtnnbr opened this issue Feb 4, 2020 · 2 comments

Comments

@mrtnnbr
Copy link

mrtnnbr commented Feb 4, 2020

MWE:

`
\version "2.19.83"

\include "oll-core/package.ily"

\loadPackage \with {
modules = conditional-breaks
}
page-layout

\registerBreakSet fail
\setBreaks fail line-breaks #'(2 (3 0)))

\applyConditionalBreaks fail

{
\repeat unfold 3 { \acciaccatura d''8 c''1 }
}
`

I'll see if I can investigate the issue further, but I'll probably busy with other stuff the next few days.

@uliska
Copy link
Contributor

uliska commented Feb 4, 2020 via email

@mrtnnbr
Copy link
Author

mrtnnbr commented Feb 4, 2020

The break should be before the acciaccatura. I already tried #(ly:make-moment ...), but that actually does clash with the way page-layout seems to expect the input. (I was also mildly surprised that #'(2) and #'((2 0)) are having a different effect.)

Curiously, using an explicit use of the edition engraver does work, but has some weird interactions with the conditional-breaks module. I expanded the example a bit:

\version "2.19.83"

\include "oll-core/package.ily"

\loadPackage \with {
  modules = conditional-breaks
}
page-layout

\registerBreakSet fail
\setBreaks fail line-breaks #'((3 0) 4)

\applyConditionalBreaks fail

\consistToContexts #edition-engraver Score.Staff.Voice

\addEdition workaround

\editionMod workaround 2 #(ly:make-moment 0 4 -1 8) test.Score \break
\editionMod workaround 2 #(ly:make-moment 0 4 -1 8) breaks.Score \break

\score {
  {
    \repeat unfold 6 { \grace d''8 c''2 }

    c''2 c''2
  }

  \layout {
    \context {
      \Score
      \editionID ##f breaks
    }
  }
}

\score {
  {
    \repeat unfold 6 { \grace d''8 c''2 }

    c''2 c''2
  }

  \layout {
    \context {
      \Score
      \editionID ##f test
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants