Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] ImagePullJob support Tolerations #1694

Open
zmberg opened this issue Aug 5, 2024 · 4 comments
Open

[feature request] ImagePullJob support Tolerations #1694

zmberg opened this issue Aug 5, 2024 · 4 comments
Assignees
Milestone

Comments

@zmberg
Copy link
Member

zmberg commented Aug 5, 2024

What would you like to be added:

Why is this needed:

@zmberg zmberg added this to the 1.8 milestone Aug 5, 2024
@zerunhu
Copy link

zerunhu commented Aug 7, 2024

Can I try this issue? @zmberg

@chengjoey
Copy link
Contributor

Can I try this issue? @zmberg

just /assign yourself

@zerunhu
Copy link

zerunhu commented Aug 8, 2024

/assign @zerunhu

@zerunhu
Copy link

zerunhu commented Aug 14, 2024

Before coding, I want to confirm some design ideas to avoid developing in the wrong direction later. Please help answer these questions @zmberg @chengjoey

  1. I need to add a new field ImagePullJobSpec.ImagePullJobTemplate.Tolerations to ImagePullJob. Can I directly reference the code from api/core/v1 for this Tolerations
    Tolerations v1.Toleration json:"toleration,omitempty"
    or I need to migrate all related fields to imagepulljob_types.go?
  2. Can Tolerations be configured simultaneously with the existing selector and podSelector?
  3. I am not sure if Kruise has implemented the logic related to Tolerations and Node scheduling. If it has, I will use it directly; if not, I will implement it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants