-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: alchemlyb: the simple alchemistry library #6934
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
|
License info: ✅ License found: |
👋🏼 @orbeckst @glycodynamics, @mikemhenry, @philbiggin this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering @editorialbot generate my checklist as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of just judging this submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#REVIEW_NUMBER so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@srmnitc ) if you have any questions/concerns, thanks again for the submission, and for the reviews |
Review checklist for @glycodynamicsConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@srmnitc is there a due date? |
It would be ideal to complete the review within about 2-4 weeks. If you need more time, please let me know.
|
@srmnitc So sorry but I will have to withdraw as a reviewer, I didn't look at the author list closely when I agreed to review (my bad!) and I have a COI from publishing with one of the authors in the last 4 years |
If this is an issue (ie publishing with one of the authors in the last four years) then I would also have to withdrawn
Best wishes,
Phil
…--------------------------------------------
Prof Phil Biggin
T: 01865 613305
W: sbcb.bioch.ox.ac.uk/biggin.php
E: ***@***.***
On 27 Jun 2024, at 21:09, Mike Henry ***@***.***> wrote:
@srmnitc<https://github.com/srmnitc> So sorry but I will have to withdraw as a reviewer, I didn't look at the author list closely when I agreed to review (my bad!) and I have a COI from publishing with one of the authors in the last 4 years
—
Reply to this email directly, view it on GitHub<#6934 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMMKVGQUDWR5C2XR23UIMSDZJRWODAVCNFSM6AAAAABJ7KO7RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGU4DMNJXHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
In that case I am definitely conflicted as having published with several of the authors.
Phil
…-----------------------------------------------------------
Prof Phil Biggin
Professor of Computational Biochemistry
Chair of the Molecular Graphics and Modelling Society
Fellow and Tutor at Lady Margaret Hall, Oxford
Department of Biochemistry
South Parks Road
Oxford
OX1 3QU
E: ***@***.***
W: sbcb.bioch.ox.ac.uk/biggin.php
T: +44 1865 613305
On 28 Jun 2024, at 01:14, Mike Henry ***@***.***> wrote:
@philbiggin<https://github.com/philbiggin> This is the policy https://joss.readthedocs.io/en/latest/reviewer_guidelines.html#joss-conflict-of-interest-policy fyi
—
Reply to this email directly, view it on GitHub<#6934 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMMKVGW2FJJKN75DHBMIHLTZJSTHRAVCNFSM6AAAAABJ7KO7RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVHA3DEMZTGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@mikemhenry and @philbiggin thank you for bringing this up. I will unassign you as reviewers. Thanks for your efforts nevertheless! |
@editorialbot remove @mikemhenry from reviewers |
@mikemhenry removed from the reviewers list! |
@editorialbot remove @philbiggin from reviewers |
@philbiggin removed from the reviewers list! |
@editorialbot add @ryankzhu as reviewer |
@ryankzhu added to the reviewers list! |
@ryankzhu thanks for agreeing to be reviewer. You can start you review by using |
Review checklist for @ryankzhuConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot set 2.4.1 as version |
Done! version is now 2.4.1 |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5896, then you can now move forward with accepting the submission by compiling again with the command |
@orbeckst Thank you for your patience, our editor in charge will take a look and finish the rest of the steps. Thanks a lot for making all the changes, and for this nice submission to JOSS. |
Thank you very much, especially for the excellent review process! |
@orbeckst as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I will now process these final checks: Checks on repository
Checks on review issue
Checks on archive
Checks on paper
Remaining points:As you can see, most seems in order, however the below are some points that require your attention 👇 :
|
@Kevin-Mattheus-Moerman I spelled out USA in the affiliations. However, I do not know how to address the point about the authorship list in the zenodo archive. The author list of the paper differs from the list of contributors on the software. Not all software authors chose to be authors on the paper or their contributions did not warrant authorship (as already discussed with @srmnitc ). However, every author on the zenodo archive is either an author of the paper or mentioned in the Acknowledgements of the paper. I cannot change the author list on the zenodo archive to conform to the paper list. If JOSS insists on these two lists being identical I will have to manually create a zenodo submission with a release tar ball included. (I was happy that I could use the automatic zenodo archive, that is tightly linked to the GitHub repo, for the JOSS paper submission but if needed will create a manual dump archive.) |
@editorialbot generate pdf |
@orbeckst thanks for updating the affiliations. On the contributors being listed on the archive, that is okay. We can keep that the way it is. I will now proceed to process this work for acceptance. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@orbeckst congratulations on this JOSS publication! Thanks for editing @srmnitc ! And a special thanks to the reviewers: @glycodynamics, @ryankzhu !!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @orbeckst (Oliver Beckstein)
Repository: https://github.com/alchemistry/alchemlyb
Branch with paper.md (empty if default branch): 71-joss-paper
Version: 2.4.1
Editor: @srmnitc
Reviewers: @glycodynamics, @ryankzhu
Archive: 10.5281/zenodo.13799342
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@glycodynamics & @mikemhenry & @philbiggin, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @srmnitc know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @glycodynamics
📝 Checklist for @ryankzhu
The text was updated successfully, but these errors were encountered: