Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hash router #61

Open
friedger opened this issue Feb 12, 2019 · 14 comments
Open

Use hash router #61

friedger opened this issue Feb 12, 2019 · 14 comments
Labels
bounty bug Something isn't working

Comments

@friedger
Copy link
Member

friedger commented Feb 12, 2019

Currently the app menu uses redux store to change the state of UI.
This issue is about

  • adding hash router to the app for the following screens
    • all -> EventCalendar
    • public -> EventCalendar with filter on public calendar
    • settings -> Settings
    • files -> Export (in feature/export branch)
  • removing the properties that manage the screens from the redux store
  • adjusting the connect* files to change the location (using history API)
  • adjusting the way intents are handled, i.e. change location (together redux store changes)
  • adding tests that clicks on the app menu changes indeed the screen

While doing the changes keep in mind that

  • the app should load fast and be as much PWA as possible
  • we use lazy loading for some screens
  • the work should be submitted together with the export feature (currently feature/export or soon develop)
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.833 ETH (99.95 USD @ $119.99/ETH) attached to it as part of the openintents fund.

@friedger friedger added the bug Something isn't working label Feb 13, 2019
@friedger
Copy link
Member Author

@iamonuwa Have you progressed?

@gitcoinbot
Copy link

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

2 similar comments
@gitcoinbot
Copy link

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@eswarasai
Copy link

@gitcoinbot -- still working on this!

@eswarasai
Copy link

Depends on #80 which is still a WIP

@PierrickGT
Copy link

Hi @friedger,
Is this still an issue you wish to fund through Gitcoin?

@gitcoinbot
Copy link

gitcoinbot commented Sep 13, 2019

Issue Status: 1. Open 2. Cancelled


Workers have applied to start work.

These users each claimed they can complete the work by 2 years, 10 months ago.
Please review their action plans below:

1) thecyberd3m0n has applied to start work (Funders only: approve worker | reject worker).

it should take about a week, my approach is to work on it about 2hours a day at morning (I have also commercial projects that I must spend time on)

I have good frontend/Javascript background in both Angular and React. Please consider my application
2) anshumanv has applied to start work (Funders only: approve worker | reject worker).

Will go through the list of requirements and implement all the points while cleaning up code and adding tests. Will frequently update of the progress.

Learn more on the Gitcoin Issue Details page.

@thecyberd3m0n
Copy link

is it still active from gitcoin perspective?

Second question - how to login blockstack locally? How do you develop the app?

@friedger
Copy link
Member Author

friedger commented Sep 17, 2019 via email

@thecyberd3m0n
Copy link

thecyberd3m0n commented Sep 17, 2019

on local blockstack I've got "Failed to fetch information about the app requesting authentication. Please contact the app maintainer to resolve the issue." I've changed start_url in manifest.json to localhost:3001 also and still same result. I can access Blockstack on port 8888

(SSR) Do you mean moving project to gatsby? It's best way you can achieve SSR with React app. It's good approach for really big apps, your app is not so big and works fast on production (if you want my opinion - performance is not a problem here)

@friedger
Copy link
Member Author

for the error, you might need to enable a cors plugin or launch the app form 127.0.0.1 (depending on the browser)

(SSR) the issue is deep linking.

@thecyberd3m0n
Copy link

thecyberd3m0n commented Sep 17, 2019

can I somehow help with it? Moving project to gatsby would help (SSR by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants