Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optional new log viewer for early boot #1921

Open
rkoshak opened this issue Oct 18, 2024 · 10 comments
Open

Implement optional new log viewer for early boot #1921

rkoshak opened this issue Oct 18, 2024 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed nice to have Makes life easier optional component Not part of the base system

Comments

@rkoshak
Copy link

rkoshak commented Oct 18, 2024

Issue information:

There was a recent thread on the forum pointing out that Frontail has not only not received any updates for some years but also has more than one pretty significant known vulnerabilities. Assuiming we don't want to take over for Frontail development and since we don't yet have a native log viewing service (though I think the core changes are made and we mainly just need the MainUI) we should consider whether it makes sense to switch to an alternative in the mean time.

https://community.openhab.org/t/security-vulnerabilities-in-frontail/159493

An alternative mentioned on that thread is https://github.com/logdyhq/logdy-core though I'm sure it's worth doing a survey to see what other alternatives there are. I can say that logdy looks a lot more capable compared to Frontail.

@miloit
Copy link

miloit commented Nov 28, 2024

Is this really necessary if this is coming?

openhab/openhab-webui#2884

@ecdye
Copy link
Contributor

ecdye commented Nov 30, 2024

It may not be necessary anymore, @rkoshak what do you think? Does it make more sense to simply ride out frontail until it gets merged?

@rkoshak
Copy link
Author

rkoshak commented Nov 30, 2024

yes, my plan is to close this once Chris's pr gets merged

@rkoshak
Copy link
Author

rkoshak commented Dec 9, 2024

Now that Chris's PR is merged there is now a log viewer as part of main UI. I'll close this one.

@rkoshak rkoshak closed this as completed Dec 9, 2024
@ecdye
Copy link
Contributor

ecdye commented Dec 9, 2024

Awesome, once it is fully rolled out to the users, we can remove frontail from systems.

@miloit
Copy link

miloit commented Dec 15, 2024

@rkoshak @ecdye I thought about it after installing and checking tne installing of RC1. Maybe it still make sense to have such a tool available because during startup phase you don't have the openhab log available.......what do you think?

@rkoshak
Copy link
Author

rkoshak commented Dec 15, 2024

I have no problems with re-opening the issue. I'm not sure how to do that from my phone though so it'll have to wait until I can get to a desktop unless someone else in this thread can do it.

@ecdye
Copy link
Contributor

ecdye commented Dec 15, 2024

@rkoshak @ecdye I thought about it after installing and checking tne installing of RC1. Maybe it still make sense to have such a tool available because during startup phase you don't have the openhab log available.......what do you think?

I think that is fine, however I think its pretty low on the priority list right now, but if you want to take it on that is fine with me.

@ecdye ecdye reopened this Dec 15, 2024
@ecdye ecdye changed the title Frontail is abandoned Implement optional new log viewer for early boot Dec 15, 2024
@ecdye ecdye added enhancement New feature or request help wanted Extra attention is needed optional component Not part of the base system nice to have Makes life easier labels Dec 15, 2024
ecdye added a commit to ecdye/openhabian that referenced this issue Dec 15, 2024
See openhab#1921 for more specific details for the reasoning.

Signed-off-by: Ethan Dye <[email protected]>
ecdye added a commit that referenced this issue Dec 18, 2024
See #1921 for more specific details for the reasoning.

Signed-off-by: Ethan Dye <[email protected]>
@mstormi
Copy link
Contributor

mstormi commented Dec 18, 2024

Very much of a sidenote, but once we have decided in favor of a solution, please evaluate if that can also be used to provide
logging on the very initial openHABian setup process, the log server on port 81.
That currently is a very rough-edged minimum hack rather than a real feature.

@rkoshak
Copy link
Author

rkoshak commented Dec 18, 2024

Very much of a sidenote, but once we have decided in favor of a solution, please evaluate if that can also be used to provide logging on the very initial openHABian setup process, the log server on port 81.

I was just comming here to add a comment saying as much as well. There's that initial setup where it would be great to have access to the logs in a browser too.

That may be a strike against my idea to step back and see if we could solve this problem and probide more features by researching web based ssh tools instead of a dedicated log viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed nice to have Makes life easier optional component Not part of the base system
Projects
None yet
Development

No branches or pull requests

4 participants