Policy for closing abandoned PR's #16702
lsiepel
announced in
Add-on Maintainers Discussions
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Since we have stale bot for issues and that seems to work very wel, it might be good to discuss what to do with the PR's. The issue discussion is here: openhab/openhab-core#3502 and i must agree that it is better not to add stale bot to PR's.
I try to keep looking at older PR's to get them across the finish line. This takes time and in some cases it leads to success, but not always. For those cases i think it is better to give up and close them without spending anymore time on them. They can always be re-opened later.
So the question is can we come up with some guideline when to close a stale PR until the author picks it up again or not?
After 18 months of inactivity from the PR-author it is very unlickely that he will continue or later on maintain the binding. Today i added the stale label to all PR's that match this criteria. I would opt to use this to start with this and close those PR's with 18months+ of inactivty.
https://github.com/openhab/openhab-addons/pulls?q=is%3Aopen+label%3Astale+is%3Apr
Can we use this as a general rule?
Beta Was this translation helpful? Give feedback.
All reactions