Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure of the package #46

Open
felix-schott opened this issue Oct 13, 2023 · 0 comments
Open

Structure of the package #46

felix-schott opened this issue Oct 13, 2023 · 0 comments

Comments

@felix-schott
Copy link
Collaborator

Description

Two things that I'm unclear about:

  1. Not quite sure what the purpose of common.py is - can this be deleted?
  2. I would also recommend to move utility functions to a utils.py file and further put all CLI handlers in the cli.py file, with a clear separation of CLI handler (command line interface) and library function (python interface). E.g. not quite clear sure why download_buildings also contains CLI handlers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felix-schott