Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little papercuts #5827

Open
4 tasks
teolemon opened this issue Nov 9, 2024 · 3 comments
Open
4 tasks

Little papercuts #5827

teolemon opened this issue Nov 9, 2024 · 3 comments

Comments

@teolemon
Copy link
Member

teolemon commented Nov 9, 2024

What

  • Bad translation in Turkish
  • the add price icon in edit mode should be the same as the one in the action bar
  • Dark mode issue in edit mode
  • dark mode issue in Road to Scores

Screenshot_20241108-181203.png

Screenshot_20241109-132322.png

Screenshot_20241108-132253.png

Screenshot_20241109-132336.png

Screenshot_20241109-132305.png

@g123k
Copy link
Collaborator

g123k commented Nov 10, 2024

Two issues are fixed in #5829

One suggestion (but I'm not sure it's relevant).
On the product page, the AppBar has two lines : name and brands
On the edit page, name and brands are on the same line and the barcode is visible when scrolling.

Should we harmonize that behavior? Or is-it OK?

@teolemon
Copy link
Member Author

  • Actually, SSS is the proper Turkish translation, not a bug (I had already spotted it and forgotten about it).
  • @g123k maybe not, the barcode has more value in edit mode, and it might be noise elsewhere. That said we show the barcode in the view as well in edit mode, right ? so we might remove it from the header.

@teolemon
Copy link
Member Author

@g123k also, pressing the visual barcode in edit mode, I would expect it to copy it. We have a copy button directly in the top bar which currently does that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

2 participants