Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data quality error: category and computed Nutri-Score is not coherent #8353

Open
Tracked by #5517
CharlesNepote opened this issue Apr 24, 2023 · 7 comments
Open
Tracked by #5517
Assignees
Labels
categories 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🚦 Nutri-Score ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@CharlesNepote
Copy link
Member

CharlesNepote commented Apr 24, 2023

The Nutri-Score of some categories is predictable. Eg:

  • Extra-virgin olive oils => Nutri-Score C
  • Apples => A
  • etc.

If an extra-virgin olive oils is not Nutri-Score C, then:

  • either the category is wrong
  • either the nutrition facts are wrong.

In both cases, it's an error, there can't be false positives. It should lead to a data-quality-error, and not just a warning.

It probably represent thousands of products. For example, as of today (2023-04), 677 olive oils have a Nutri-Score different from C.

To let it scale, I would be in favor to add this data in the taxonomy. Eg. (look at the last line):

<en:Virgin olive oils
en:Extra-virgin olive oils, Extra virgin olive oil
bg:Зехтин екстра върджин
de:Native Olivenöle Extra, Natives Olivenöl Extra
fr:Huiles d'olive vierges extra, Huile d'olive vierge extra
agribalyse_food_code:en:17270
ciqual_food_code:en:17270
ciqual_food_name:en:Olive oil, extra virgin
ciqual_food_name:fr:Huile d'olive vierge extra
expected_nutriscore:en:c
expected_ingredients_text:en:Olive oil

Part of

@CharlesNepote CharlesNepote added categories 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore 🧽 Data quality https://wiki.openfoodfacts.org/Quality labels Apr 24, 2023
@benbenben2 benbenben2 moved this from To do to In progress in 🧽 Ensuring Data Quality May 21, 2023
@benbenben2 benbenben2 self-assigned this May 21, 2023
@benbenben2 benbenben2 moved this from In progress to Needs review in 🧽 Ensuring Data Quality May 21, 2023
@benbenben2
Copy link
Collaborator

@CharlesNepote, is it done?

@CharlesNepote
Copy link
Member Author

I guess this is not done yet. I have just modified this olive oil, but it's still Nutri-Score D and without data quality error: https://world.openfoodfacts.org/product/001682/minotaur-bio-huile-d-olive-vierge-extra
Maybe @stephanegigandet has to launch taxonomy deployment or some task I don't know of.

@benbenben2
Copy link
Collaborator

DQ errors are there now @CharlesNepote

@CharlesNepote
Copy link
Member Author

Yes. For the record:

Also added to: https://wiki.openfoodfacts.org/List_of_data_quality_errors_(generated)

Before closing I'm going to open another issue to gather more products with only one ingredient, and/or product categories which should have only one Nutri-Score.

Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Dec 18, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@benbenben2
Copy link
Collaborator

@CharlesNepote, is there anything else to do with this issue?

@teolemon teolemon added 🚦 Nutri-Score and removed 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore labels May 11, 2024
@CharlesNepote
Copy link
Member Author

Stats for 2024-09-02:

In most case this is due to olive oil which should always contain only "olive oil" but which often countain "olive oil manually blah blah blah".

Should en:ingredients-single-ingredient-from-category-does-not-match-actual-ingredients be an error or a warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🚦 Nutri-Score ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To discuss and validate
Status: No status
Status: Needs review
Development

No branches or pull requests

3 participants