Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevention - New edit rules to ignore or notify edits that match given conditions #798

Open
Tracked by #10272
stephanegigandet opened this issue Apr 17, 2017 · 1 comment
Assignees
Labels
automation 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🧽 Data quality https://wiki.openfoodfacts.org/Quality Fixed ? This issue might have been fixed. We can close them once we verify that they have.

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Apr 17, 2017

What

We need a new system to easily add rules that can be triggered when products are edited and when the edits match given conditions.

In particular this is needed to ignore unwanted edits from apps.

Proposed features and format:


@edit_rules = (

{
	name => "App XYZ",
	conditions => [
		user_id => "xyz",
	],
	actions => {
		ignore_if_existing_ingredients_texts_fr => 1,
		ignore_if_0_nutriments_fruits-vegetables-nuts_100g => 1,		
		warn_if_match_nutriments_fruits-vegetables-nuts_100g => 100,
		ignore_if_regexp_match_packaging => "^(artikel|produit|producto|produkt|produkte)$",
	},
	notifications => qw (
		[email protected]
		slack_channel_edit-alert
		slack_channel_edit-alert-xyz
	),
},


);

Part of

@teolemon teolemon added this to the Data Quality Checks milestone Apr 17, 2017
@teolemon
Copy link
Member

teolemon commented May 2, 2017

Can we close ?

@teolemon teolemon added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Oct 10, 2017
@teolemon teolemon added the 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits label Jun 25, 2018
@hangy hangy added the Fixed ? This issue might have been fixed. We can close them once we verify that they have. label May 12, 2019
@teolemon teolemon changed the title New edit rules to ignore or notify edits that match given conditions Prevention - New edit rules to ignore or notify edits that match given conditions Oct 11, 2021
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🧽 Data quality https://wiki.openfoodfacts.org/Quality Fixed ? This issue might have been fixed. We can close them once we verify that they have.
Projects
Status: To discuss and validate
Status: To do
Development

No branches or pull requests

3 participants