-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality facet - Nutrition - serving_size="serving" for data-quality #5163
Comments
|
This issue is stale because it has been open 90 days with no activity. |
corresponding code is in DataQualityFood.pm |
This would lead to increase data quality errors from 5.78% to ~6.16% for an issue that is having no impact on Nutri-Score, Nova, etc. for at least more than 10%. So I would be in favour to:
Maybe 2 can be done before 1. |
Just checked with Mirabelle, that could include some values like "-" (6), "une tranche" (1), "une noisette" (1), "une pression par narine" (1), "une cuillere à café" (1), "une biscotte g" (1), "tbsp" (1), "servingg" (1), etc. |
@benbenben2 yes why not. There are 227 different values for this field. Most of them are given once but it would be nice to detect it. The hyphen ( @stephanegigandet can you confirm there is no reason not to have at least one number in this field? |
It's a free form field, so we can have anything in it. We could have a warning when there isn't a number, but I wouldn't make it an error. What would be interesting is a quality warning when we don't have a value for serving size, or we have a value that we can't convert to g/ml, AND we have nutrition facts indicated per serving. In that case, while we have nutrition facts, we can't compute Nutri-Score etc |
Do you see some examples where a value without a number would be relevant?
So I would tend to conclude that:
So I would count all these values as "data quality errors" and, while we don't do it automaticaly, let people manually fix "non communiqué" into "-".
At least we could do this. But honestly, currently quality warnings are not read by anyone (or so few). And there is currently no easy way to tag a warning as "checked". So for all the reasons I mentioned in this comment, I think it should be a data quality error. |
OK. |
* Add en:Serving size is missing digits See #5163 and #8057. * ci: autolabel changes to the taxo --------- Co-authored-by: Pierre Slamich <[email protected]>
@CharlesNepote, is it solved by this PR #8091? |
I think so, let's close it :-) |
What
Hello,
It seems that a few users (or applications) sometimes mistakenly indicate "serving" as the portion size.
A facet to detect and correct this could be useful.
Thanks
Bonjour,
Il semblerait que quelques utilisateurs (ou applications) indiquent parfois par erreur "serving" comme taille de portion.
Une facette pour détecter et corriger ça pourrait être utile.
Merci
Part of
The text was updated successfully, but these errors were encountered: