Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer Platform - Don't require the user to remain online during all the duration of the upload of images #3591

Closed
2 tasks
Tracked by #5521
teolemon opened this issue Jun 11, 2020 · 4 comments
Labels
🐛 bug This is a bug, not a feature request. ✨ Feature Features or enhancements to Open Food Facts server 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@teolemon
Copy link
Member

teolemon commented Jun 11, 2020

Ask: Don't require the user to remain online during all the duration of the upload of images on the manufacturer platform.
Rationale: The design choice of using Javascript is questionable. It stalls on large uploads, maxxing out CPU and Memory, even on brand new upscale computers (the one corporates don't have), and requires the user to stay connected for 10 hours +, with no resume solution.

  • A proposed solution would be to upload all the files in parallel or to upload a complete ZIP archive.
  • Having the possibility to pre-upload via FTP for power users would be nice

Part of

@teolemon teolemon added 🐛 bug This is a bug, not a feature request. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers ✨ Feature Features or enhancements to Open Food Facts server labels Jun 11, 2020
@teolemon
Copy link
Member Author

Case in point, after checking, the whole image folder is 1,1GB unzipped, something that uploads quickly on a modern connexion and could be handled afterwards by the server, and then the user could be mailed once it's ready for review.
I've been at it since 2PM yesterday. File by file upload is flawed.

@hangy
Copy link
Member

hangy commented Jun 11, 2020

The design choice of using Javascript is questionable. It stalls on large uploads, maxxing out CPU and Memory, even on brand new upscale computers (the one corporates don't have)

What do we do during the upload? Maxing out memory and CPU for a JPEG upload sounds weird. Any idea what the bottleneck is? I haven't used/seen the 'producer' platform, yet. Do we have any browser benchmarks/traces?

and requires the user to stay connected for 10 hours +, with no resume solution.

How many images (at which average size) are we talking about? At 10 Mbit/s upload speed, you could theoretically upload up to 45 GB.

A proposed solution would be to upload all the files in parallel

If the PC is at 100% utilisation, parallel upload won't help.

or to upload a complete ZIP archive.

That could work, unless we do any preprocessing in the browser. Again the file size would be of interest. HTML uploads can be made resumable, with the help of some server adjustments.

Having the possibility to pre-upload via FTP for power users would be nice

That would add another infrastructure component that needs to be maintained. Would we want individual accounts for every off user?

@stephanegigandet
Copy link
Contributor

@hangy You can try the pro platform on https://world.pro.openfoodfacts.dev

This was to upload 10 000 images for a total size of 1.1 Gb.

This image upload form is clearly not targeted for that kind of use (but it's great that it does work anyway, even if it is slow and not convenient), it's expected that most users will send less than 1000 photos at once. We show them thumbnails so that they can check they are uploading the right images etc.

The form creates a table, with thumbnails of the images. Browsers are not good at handling tables with 10 000 rows, with 10 000 images...

We could create another feature to upload a zip file with tons of images, and process it afterwards.

@hangy
Copy link
Member

hangy commented Jun 14, 2020

The form creates a table, with thumbnails of the images. Browsers are not good at handling tables with 10 000 rows, with 10 000 images...

Not really, no. 😄

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 30, 2021
@teolemon teolemon changed the title Don't require the user to remain online during all the duration of the upload of images on the manufacturer platform Producer Platform - Don't require the user to remain online during all the duration of the upload of images Sep 21, 2021
@manon-corneille manon-corneille moved this from Triage needed to Closed by Manon in 🏭 Producers Platform Dec 20, 2023
@manon-corneille manon-corneille closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2023
@github-project-automation github-project-automation bot moved this from Closed by Manon to Done in 🏭 Producers Platform Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. ✨ Feature Features or enhancements to Open Food Facts server 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: Done
Development

No branches or pull requests

4 participants