Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All integer registers forced to signed int #192

Open
borpin opened this issue Feb 10, 2023 · 0 comments
Open

All integer registers forced to signed int #192

borpin opened this issue Feb 10, 2023 · 0 comments

Comments

@borpin
Copy link
Contributor

borpin commented Feb 10, 2023

emonhub/src/interfacers/EmonHubMinimalModbusInterfacer.py

Line 173 in ebbaa96

if self.datatype == 'int':

There should be a new datatype of unsigned_Int

Commiting to the master branch directly rather than by PR is also a bad idea (IMHO).

ebbaa96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@borpin