Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding _in validators to attr classes #348

Open
mariajgrimaldi opened this issue May 14, 2024 · 0 comments
Open

Allow adding _in validators to attr classes #348

mariajgrimaldi opened this issue May 14, 2024 · 0 comments
Labels
enhancement Relates to new features or improvements to existing features

Comments

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented May 14, 2024

As per my question [here](Here's the original thread: https://openedx.slack.com/archives/C03SDBSFUUB/p1714139377765319):

There's a new event in progress here, which included a status str attribute with a validator: https://github.com/openedx/openedx-events/pull/303/commits/8558418e230edcf29687661bcdb3def5bb1a58bc#diff-5cf3a0b26961626ce[…]a35d078cb9c62438fa3R521. Without this modification tests would fail because of the validator, but the change was too specific for this use case, so the team implementing the event decided to drop the validator altogether. The thing is, we should be able to add this kind of stuff, so should we implement a workaround for it?

I'm opening this issue so we can go back to it in the future.

@mariajgrimaldi mariajgrimaldi added the enhancement Relates to new features or improvements to existing features label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant