Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add atlas in package.json #378

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

Ali-D-Akbar
Copy link
Contributor

Adds the missing atlas package for new pull translation.

@Ali-D-Akbar Ali-D-Akbar force-pushed the aakbar/fix-missing-atlas branch from fe3b441 to 257824d Compare March 26, 2024 19:34
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (c7b0faf) to head (d5c7cd5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files         164      164           
  Lines        3448     3448           
  Branches      850      850           
=======================================
  Hits         3046     3046           
  Misses        398      398           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit type should be chore, not feat.

@Ali-D-Akbar Ali-D-Akbar force-pushed the aakbar/fix-missing-atlas branch from 257824d to d5c7cd5 Compare March 27, 2024 08:20
@Ali-D-Akbar Ali-D-Akbar changed the title feat: add atlas in package.json chore: add atlas in package.json Mar 27, 2024
@Ali-D-Akbar Ali-D-Akbar merged commit 124cebd into master Mar 27, 2024
7 checks passed
@Ali-D-Akbar Ali-D-Akbar deleted the aakbar/fix-missing-atlas branch March 27, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants