ENT-7820 Learner Credit table sorting

[jono-booth]

There were a couple issues with the sortDataTableData method.

1. It wasn't returning the result of the ternary, so needed to set the result to a var and return the var
2. lodash.snakecase was stripping out the - which is used for sorting in reverse. Moved the snakecase call before the - was prepended.

Added some test for asc and desc sorting.

[brobro10000]

Running the PR locally, it is sorting as expected 👍🏽 but noticed some failing tests. Will run the CI on this for now while it gets corrected.

[brobro10000]

Instead of fireEvent the repo is leaning towards userEvent in testing. See

frontend-app-support-tools/src/Configuration/Provisioning/ProvisioningForm/PolicyForm/tests/ProvisioningFormPolicyContainer.test.jsx

Lines 69 to 90 in f00e83f

	it('renders policy type and selects AssignedLearnerCreditAccessPolicy', async () => {
	const updatedInitialState = {
	...initialStateValue,
	multipleFunds: false,
	formData: {
	...initialStateValue.formData,
	policies: INITIAL_POLICIES.singlePolicy,
	},
	};
	renderWithRouter(
	<ProvisioningFormPolicyContainerWrapper
	value={updatedInitialState}
	sampleCatalogQuery={INITIAL_POLICIES.singlePolicy}
	/>,
	);
	expect(screen.getByText(POLICY_TYPE.TITLE)).toBeTruthy();
	expect(screen.getByText(POLICY_TYPE.LABEL)).toBeTruthy();
	userEvent.click(screen.getByTestId(POLICY_TYPE.OPTIONS.ADMIN_SELECTS.DESCRIPTION));
	await waitFor(() => {
	expect(screen.getByTestId(POLICY_TYPE.OPTIONS.ADMIN_SELECTS.DESCRIPTION).checked).toBeTruthy();
	});
	});

for an example of its usage

import userEvent from '@testing-library/user-event';

const tableHeader = screen.getByText('Start date');

    userEvent.click(tableHeader);

[brobro10000]

Noticed some linting errors on this PR. Running the script npm run lint should point out where those linting errors exists and how to correct them.

[jono-booth]

Running the PR locally, it is sorting as expected 👍🏽 but noticed some failing tests. Will run the CI on this for now while it gets corrected.

Thanks for the feedback. Sorted the linting issues out and using userEvent instead of fireEvent in the test.

[brobro10000]

LGTM 👍🏽 Great job

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f00e83f) 88.09% compared to head (bc01aa4) 88.10%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   88.09%   88.10%   +0.01%     
==========================================
  Files         162      162              
  Lines        3377     3380       +3     
  Branches      837      836       -1     
==========================================
+ Hits         2975     2978       +3     
  Misses        398      398              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.