feat: Re-enable Docker image builds for arm64 #2546
Conversation
The maintainers of `didkit` have released an update that fixes an issue where it would not build on arm64-based systems. This resolves an issue with Devstack and developers running devstack on Apple silicon-based machines.
| @@ -385,7 +385,7 @@ proto-plus==1.24.0 | |||
| # -r requirements/base.txt | |||
| # google-api-core | |||
| # google-cloud-firestore | |||
| protobuf==4.25.4 | |||
| protobuf==5.27.3 | |||
There was a problem hiding this comment.
Nitpicking: Have we checked that this major version upgrade is good to go?
There was a problem hiding this comment.
Good eye. I scanned the updates quickly and missed this one. good catch and thanks for pointing it out. I will confirm before merging this.
There was a problem hiding this comment.
I'm having a harder time finding release notes on this than I expected. Since this is a requirement of other dependencies, I'm going to roll with it and I'll keep an eye on the deployments.
I did check to see what version other projects are using across the openedx and edx repos, and I see some folks using the 5.x versions. I haven't heard anything internally about issues with this version.
|
@GlugovGrGlib just a courtesy tag, this PR is where |
- The maintainers of `didkit` have released an update that fixes an issue where it would not build on arm64-based systems. This resolves an issue with Devstack and developers running devstack on Apple silicon-based machines. - this fix is merged in master, backporting this fix to work with redwood. openedx#2546
- The maintainers of `didkit` have released an update that fixes an issue where it would not build on arm64-based systems. This resolves an issue with Devstack and developers running devstack on Apple silicon-based machines. - this fix is merged in master, backporting this fix to work with redwood. openedx#2546
The maintainers of
didkithave released an update that fixes an issue where it would not build on arm64-based systems.This resolves an issue with Devstack and developers running devstack on Apple silicon-based machines.
Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma