-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace use of mustache templates with edx-utils template #105
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Also removes underscore-min.js file which was unused
728d9cb
to
aeb3fb1
Compare
@farhan Could you please review these changes? |
Sure, let me prioritize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work overall in removing legacy code.
But it will be great if we could directly update the template library to Django Template Library rather than to Mako templates, because we have already parted ways with Mako templates and shifting the code to Django templates library.
Also removes underscore-min.js file which was unused