Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace use of mustache templates with edx-utils template #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

navinkarkera
Copy link
Contributor

Also removes underscore-min.js file which was unused

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 19, 2024

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @navinkarkera.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@navinkarkera navinkarkera added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. blocked by other work PR cannot be finished until other work is complete and removed blocked by other work PR cannot be finished until other work is complete waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jan 20, 2025
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jan 24, 2025
@navinkarkera navinkarkera force-pushed the navin/remove-mustache branch from 728d9cb to aeb3fb1 Compare January 29, 2025 13:48
@navinkarkera navinkarkera marked this pull request as ready for review January 29, 2025 13:48
@navinkarkera
Copy link
Contributor Author

@farhan Could you please review these changes?

@itsjeyd itsjeyd requested a review from farhan January 30, 2025 12:21
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jan 30, 2025
@farhan
Copy link

farhan commented Feb 4, 2025

@farhan Could you please review these changes?

Sure, let me prioritize it.

Copy link

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work overall in removing legacy code.

But it will be great if we could directly update the template library to Django Template Library rather than to Mako templates, because we have already parted ways with Mako templates and shifting the code to Django templates library.

ADR:
https://github.com/openedx/open-edx-proposals/blob/ba75a70d7b062426403667822978f101d71fce2d/oeps/best-practices/oep-0067/decisions/frontend/0005-django-templates.rst#L24

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

4 participants